mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ci: add logging to uploading to GitHub releases (#41453)

Browse source
This commit is contained in:
John Kleinschmidt 2024-02-27 19:55:08 -05:00 committed by GitHub
parent b468b5e6e8
commit 267c0796dd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
script/release/uploaders/upload-to-github.ts
View file

@ -27,7 +27,9 @@ const getHeaders = (filePath: string, fileName: string) => {
if (!extension) { if (!extension) {
throw new Error(`Failed to get headers for extensionless file: ${fileName}`); throw new Error(`Failed to get headers for extensionless file: ${fileName}`);
} }
console.log(`About to get size of ${filePath}`);
const size = fs.statSync(filePath).size; const size = fs.statSync(filePath).size;
console.log(`Got size of ${filePath}: ${size}`);
const options: Record<string, string> = { const options: Record<string, string> = {
json: 'text/json', json: 'text/json',
zip: 'application/zip', zip: 'application/zip',
@ -46,10 +48,13 @@ const uploadUrl = `https://uploads.github.com/repos/electron/${targetRepo}/relea
let retry = 0; let retry = 0;
function uploadToGitHub () { function uploadToGitHub () {
console.log(`in uploadToGitHub for ${filePath}, ${fileName}`);
const fileData = fs.createReadStream(filePath);
console.log(`in uploadToGitHub, created readstream for ${filePath}`);
octokit.repos.uploadReleaseAsset({ octokit.repos.uploadReleaseAsset({
url: uploadUrl, url: uploadUrl,
headers: getHeaders(filePath, fileName), headers: getHeaders(filePath, fileName),
data: fs.createReadStream(filePath) as any, data: fileData as any,
name: fileName, name: fileName,
owner: 'electron', owner: 'electron',
repo: targetRepo, repo: targetRepo,

9
script/release/uploaders/upload.py
View file

@ -362,10 +362,13 @@ def upload_io_to_github(release, filename, filepath, version):
(filename)) (filename))
script_path = os.path.join( script_path = os.path.join(
ELECTRON_DIR, 'script', 'release', 'uploaders', 'upload-to-github.ts') ELECTRON_DIR, 'script', 'release', 'uploaders', 'upload-to-github.ts')
upload_gh_output = execute([TS_NODE, script_path, filepath, filename, upload_process = subprocess.Popen([TS_NODE, script_path, filepath, filename,
str(release['id']), version]) str(release['id']), version], stdout=subprocess.PIPE,
stderr=subprocess.STDOUT)
if is_verbose_mode(): if is_verbose_mode():
print(upload_gh_output) for c in iter(lambda: upload_process.stdout.read(1), b""):
sys.stdout.buffer.write(c)
sys.stdout.flush()
def upload_sha256_checksum(version, file_path, key_prefix=None): def upload_sha256_checksum(version, file_path, key_prefix=None):