mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve error message for type error

Browse source 
Close atom/electron#4307.
This commit is contained in:
Cheng Zhao 2016-02-02 10:10:15 +08:00
parent a3dcf8ced6
commit 26520c5cf4
1 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
native_mate/arguments.cc
View file

@ -9,6 +9,23 @@
namespace mate {
namespace {
std::string V8TypeAsString(v8::Local<v8::Value> value) {
if (value.IsEmpty())
return "<empty handle>";
if (value->IsUndefined())
return "undefined";
if (value->IsNull())
return "null";
std::string result;
if (!ConvertFromV8(NULL, value, &result))
return std::string();
return result;
}
} // namespace
Arguments::Arguments()
: isolate_(NULL),
info_(NULL),
@ -37,7 +54,8 @@ v8::Local<v8::Value> Arguments::ThrowError() const {
return ThrowTypeError("Insufficient number of arguments.");
return ThrowTypeError(base::StringPrintf(
"Error processing argument %d.", next_ - 1));
"Error processing argument at index %d, conversion failure from %s",
next_, V8TypeAsString((*info_)[next_]).c_str()));
}
v8::Local<v8::Value> Arguments::ThrowError(const std::string& message) const {