mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix crash when return value pointer is null

Browse source
This commit is contained in:
Kevin Sawicki 2016-11-16 16:30:46 -08:00
parent cbffd598f9
commit 26137977cd
1 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

20
atom/browser/api/atom_api_system_preferences_mac.mm
View file

@ -28,17 +28,17 @@ std::map<int, id> g_id_map;
} // namespace } // namespace
void SystemPreferences::PostNotification(const std::string& name, void SystemPreferences::PostNotification(const std::string& name,
const base::DictionaryValue& user_info) { const base::DictionaryValue& user_info) {
DoPostNotification(name, user_info, false); DoPostNotification(name, user_info, false);
} }
void SystemPreferences::PostLocalNotification(const std::string& name, void SystemPreferences::PostLocalNotification(const std::string& name,
const base::DictionaryValue& user_info) { const base::DictionaryValue& user_info) {
DoPostNotification(name, user_info, true); DoPostNotification(name, user_info, true);
} }
void SystemPreferences::DoPostNotification(const std::string& name, void SystemPreferences::DoPostNotification(const std::string& name,
const base::DictionaryValue& user_info, bool is_local) { const base::DictionaryValue& user_info, bool is_local) {
NSNotificationCenter* center = is_local ? NSNotificationCenter* center = is_local ?
[NSNotificationCenter defaultCenter] : [NSNotificationCenter defaultCenter] :
@ -128,11 +128,17 @@ v8::Local<v8::Value> SystemPreferences::GetUserDefault(
return mate::ConvertToV8(isolate(), return mate::ConvertToV8(isolate(),
net::GURLWithNSURL([defaults URLForKey:key])); net::GURLWithNSURL([defaults URLForKey:key]));
} else if (type == "array") { } else if (type == "array") {
return mate::ConvertToV8(isolate(), std::unique_ptr<base::ListValue> list =
*NSArrayToListValue([defaults arrayForKey:key])); NSArrayToListValue([defaults arrayForKey:key]);
if (list == nullptr)
list.reset(new base::ListValue());
return mate::ConvertToV8(isolate(), *list);
} else if (type == "dictionary") { } else if (type == "dictionary") {
return mate::ConvertToV8(isolate(), std::unique_ptr<base::DictionaryValue> dictionary =
*NSDictionaryToDictionaryValue([defaults dictionaryForKey:key])); NSDictionaryToDictionaryValue([defaults dictionaryForKey:key]);
if (dictionary == nullptr)
dictionary.reset(new base::DictionaryValue());
return mate::ConvertToV8(isolate(), *dictionary);
} else { } else {
return v8::Undefined(isolate()); return v8::Undefined(isolate());
} }