mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: crash when alt key pressed with falsy menu bar visiblity (#17766)

Browse source
This commit is contained in:
Vlad Hashimoto 2019-04-15 20:54:27 +03:00 committed by Samuel Attard
parent 748632d655
commit 258d337cf8
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
atom/browser/ui/views/root_view.cc
View file

@ -145,9 +145,11 @@ void RootView::HandleKeyEvent(const content::NativeWebKeyboardEvent& event) {
View* focused_view = GetFocusManager()->GetFocusedView(); View* focused_view = GetFocusManager()->GetFocusedView();
last_focused_view_tracker_->SetView(focused_view); last_focused_view_tracker_->SetView(focused_view);
menu_bar_->RequestFocus(); if (menu_bar_visible_) {
// Show accelerators when menu bar is focused menu_bar_->RequestFocus();
menu_bar_->SetAcceleratorVisibility(true); // Show accelerators when menu bar is focused
menu_bar_->SetAcceleratorVisibility(true);
}
} else { } else {
// When any other keys except single Alt have been pressed/released: // When any other keys except single Alt have been pressed/released:
menu_bar_alt_pressed_ = false; menu_bar_alt_pressed_ = false;