mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Deprecate did-get-response-details and did-get-redirect-request (#12615)

Browse source 
* Deprecate webContents events did-get-response-details and did-get-redirect-request.

* Update guest view files

* Update webview tag docs and update specs

* Update deprecate.event function

* Update comment

* Update more

* Update documentation for other deprecated event
This commit is contained in:
Nitish Sakhawalkar 2018-04-23 12:46:12 -07:00 • committed by Charles Kerr
parent 975964f9f0
commit 2579071b98
10 changed files with 47 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

4
spec/webview-spec.js
View file

@ -1088,7 +1088,7 @@ describe('<webview> tag', function () {
})
})
describe('did-get-response-details event', () => {
describe('did-get-response-details event (deprecated)', () => {
it('emits for the page and its resources', (done) => {
// expected {fileName: resourceType} pairs
const expectedResources = {
@ -1096,7 +1096,7 @@ describe('<webview> tag', function () {
'logo.png': 'image'
}
let responses = 0
webview.addEventListener('did-get-response-details', (event) => {
webview.addEventListener('-did-get-response-details', (event) => {
responses += 1
const fileName = event.newURL.slice(event.newURL.lastIndexOf('/') + 1)
const expectedType = expectedResources[fileName]