mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Deprecate did-get-response-details and did-get-redirect-request (#12615)

Browse source 
* Deprecate webContents events did-get-response-details and did-get-redirect-request.

* Update guest view files

* Update webview tag docs and update specs

* Update deprecate.event function

* Update comment

* Update more

* Update documentation for other deprecated event
This commit is contained in:
Nitish Sakhawalkar 2018-04-23 12:46:12 -07:00 • committed by Charles Kerr
parent 975964f9f0
commit 2579071b98
10 changed files with 47 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spec/api-browser-window-spec.js
View file

@ -152,8 +152,8 @@ describe('BrowserWindow module', () => {
it('should not crash when invoked synchronously inside navigation observer', (done) => {
const events = [
{ name: 'did-start-loading', url: `${server.url}/200` },
{ name: 'did-get-redirect-request', url: `${server.url}/301` },
{ name: 'did-get-response-details', url: `${server.url}/200` },
{ name: '-did-get-redirect-request', url: `${server.url}/301` },
{ name: '-did-get-response-details', url: `${server.url}/200` },
{ name: 'dom-ready', url: `${server.url}/200` },
{ name: 'page-title-updated', url: `${server.url}/title` },
{ name: 'did-stop-loading', url: `${server.url}/200` },
@ -218,14 +218,15 @@ describe('BrowserWindow module', () => {
w.on('ready-to-show', () => { done() })
w.loadURL('about:blank')
})
it('should emit did-get-response-details event', (done) => {
// TODO(nitsakh): Deprecated
it('should emit did-get-response-details(deprecated) event', (done) => {
// expected {fileName: resourceType} pairs
const expectedResources = {
'did-get-response-details.html': 'mainFrame',
'logo.png': 'image'
}
let responses = 0
w.webContents.on('did-get-response-details', (event, status, newUrl, oldUrl, responseCode, method, referrer, headers, resourceType) => {
w.webContents.on('-did-get-response-details', (event, status, newUrl, oldUrl, responseCode, method, referrer, headers, resourceType) => {
responses += 1
const fileName = newUrl.slice(newUrl.lastIndexOf('/') + 1)
const expectedType = expectedResources[fileName]