mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: disable the test that makes spec runner hang on exit (#32834)

Browse source
This commit is contained in:
Cheng Zhao 2022-02-09 23:20:51 +09:00 • committed by GitHub
parent baaa7787af
commit 254dbd7400
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
spec/chromium-spec.js
View file

@ -8,7 +8,7 @@ const ChildProcess = require('child_process');
const { ipcRenderer } = require('electron'); const { ipcRenderer } = require('electron');
const { emittedOnce, waitForEvent } = require('./events-helpers'); const { emittedOnce, waitForEvent } = require('./events-helpers');
const { resolveGetters } = require('./expect-helpers'); const { resolveGetters } = require('./expect-helpers');
const { ifdescribe, delay } = require('./spec-helpers'); const { ifit, ifdescribe, delay } = require('./spec-helpers');
const features = process._linkedBinding('electron_common_features'); const features = process._linkedBinding('electron_common_features');
/* Most of the APIs here don't use standard callbacks */ /* Most of the APIs here don't use standard callbacks */
@ -81,7 +81,8 @@ describe('chromium feature', () => {
expect(event.data).to.equal(`size: ${width} ${height}`); expect(event.data).to.equal(`size: ${width} ${height}`);
}); });
it('disables node integration when it is disabled on the parent window', async () => { // FIXME(zcbenz): This test is making the spec runner hang on exit on Windows.
ifit(process.platform !== 'win32')('disables node integration when it is disabled on the parent window', async () => {
const windowUrl = require('url').format({ const windowUrl = require('url').format({
pathname: `${fixtures}/pages/window-opener-no-node-integration.html`, pathname: `${fixtures}/pages/window-opener-no-node-integration.html`,
protocol: 'file', protocol: 'file',