mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: remove deprecated app.enableMixedSandbox() (#17894)

Browse source
This commit is contained in:
Milan Burda 2019-04-24 06:07:40 +02:00 • committed by Shelley Vohr
parent 9b779657fb
commit 253d049ac9
3 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
docs/api/breaking-changes.md
View file

@ -81,6 +81,15 @@ powerMonitor.querySystemIdleTime(callback)
const idleTime = getSystemIdleTime() const idleTime = getSystemIdleTime()
``` ```
## `app.enableMixedSandbox`
```js
// Deprecated
app.enableMixedSandbox()
```
Mixed-sandbox mode is now enabled by default.
## Preload scripts outside of app path are not allowed ## Preload scripts outside of app path are not allowed
For security reasons, preload scripts can only be loaded from a subpath of the [app path](app.md#appgetapppath). For security reasons, preload scripts can only be loaded from a subpath of the [app path](app.md#appgetapppath).

5
docs/api/chrome-command-line-switches.md
View file

@ -181,6 +181,11 @@ logging level for all code in the source files under a `foo/bar` directory.
This switch only works when `--enable-logging` is also passed. This switch only works when `--enable-logging` is also passed.
## --no-sandbox
Disables Chromium sandbox, which is now enabled by default.
Should only be used for testing.
[app]: app.md [app]: app.md
[append-switch]: app.md#appcommandlineappendswitchswitch-value [append-switch]: app.md#appcommandlineappendswitchswitch-value
[ready]: app.md#event-ready [ready]: app.md#event-ready

5
lib/browser/api/app.ts
View file

@ -32,10 +32,7 @@ Object.assign(app, {
getSwitchValue: (theSwitch: string) => commandLine.getSwitchValue(String(theSwitch)), getSwitchValue: (theSwitch: string) => commandLine.getSwitchValue(String(theSwitch)),
appendSwitch: (theSwitch: string, value?: string) => commandLine.appendSwitch(String(theSwitch), typeof value === 'undefined' ? value : String(value)), appendSwitch: (theSwitch: string, value?: string) => commandLine.appendSwitch(String(theSwitch), typeof value === 'undefined' ? value : String(value)),
appendArgument: (arg: string) => commandLine.appendArgument(String(arg)) appendArgument: (arg: string) => commandLine.appendArgument(String(arg))
} as Electron.CommandLine, } as Electron.CommandLine
enableMixedSandbox () {
deprecate.log(`'enableMixedSandbox' is deprecated. Mixed-sandbox mode is now enabled by default. You can safely remove the call to enableMixedSandbox().`)
}
}) })
// we define this here because it'd be overly complicated to // we define this here because it'd be overly complicated to