mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: put empty virtual function definitions in header (#43285)

Browse source 
* refactor: in FramelessView, move empty function decls to header

* refactor: in electron::api::WebContents, move empty function decls to header

* refactor: in electron::api::NativeWindow, move empty function decls to header

* refactor: in electron::OffScreenWebContentsView, move empty function decls to header

* refactor: in electron::OffScreenRenderWidgetHostView, move empty function decls to header

* refactor: in auto_updater::AutoUpdater, move empty function decls to header

* refactor: in electorn::api::FrameSubscriber, move empty function decls to header

* refactor: in electorn::api::SimpleURLLoaderWrapper, move empty function decls to header

* refactor: in electorn::InspectableWebContents, move empty function decls to header

* refactor: in electorn::OffScreenVideoConsumer, move empty function decls to header

* refactor: in electron::OffScreenWebContentsView, move empty function decls to header

* refactor: in electron::TrayIcon, move empty function decls to header

* refactor: in electron::ViewsDelegate, move empty function decls to header

* refactor: in electron::MediaCaptureDevicesDispatcher, move empty function decls to header

* refactor: in electron::UsbChooserContext::DeviceObserver, move empty function decls to header

* refactor: in electron::ProxyingWebSocket, move empty function decls to header

* refactor: in electron::Notification, move empty function decls to header

* refactor: in electron::PlatformNotificationService, move empty function decls to header

* Revert "refactor: in electron::PlatformNotificationService, move empty function decls to header"

This reverts commit 9103750d03b9ba1ceccba43d11dfdc2404ff6191.

* refactor: in electron::ElectronPDFDocumentHelperClient, move empty function decls to header

* refactor: in electron::api::SpellCheckClient, move empty function decls to header

* refactor: in electron::ElectronExtensionHostDelegate, move empty function decls to header

* refactor: in electron::PlatformNotificationService, move empty function decls to header

* refactor: in electron::NativeWindowViews, move empty function decls to header

* chore: move SetTouchBar() back to cc

* Revert "refactor: in auto_updater::AutoUpdater, move empty function decls to header"

This reverts commit c43d6862d32c74f63f82700a7546a732ac05ecb8.
This commit is contained in:
Charles Kerr 2024-08-12 02:56:51 -05:00 • committed by GitHub
parent bff298987f
commit 23bcca3ffc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
40 changed files with 107 additions and 370 deletions
Download patch file Download diff file Expand all files Collapse all files

12
shell/browser/ui/tray_icon.h
View file

@ -36,7 +36,7 @@ class TrayIcon {
virtual void SetImage(ImageType image) = 0;
// Sets the image associated with this status icon when pressed.
virtual void SetPressedImage(ImageType image);
virtual void SetPressedImage(ImageType image) {}
// Sets the hover text for this status icon. This is also used as the label
// for the menu item which is created as a replacement for the status icon
@ -79,19 +79,19 @@ class TrayIcon {
// Displays a notification balloon with the specified contents.
// Depending on the platform it might not appear by the icon tray.
virtual void DisplayBalloon(const BalloonOptions& options);
virtual void DisplayBalloon(const BalloonOptions& options) {}
// Removes the notification balloon.
virtual void RemoveBalloon();
virtual void RemoveBalloon() {}
// Returns focus to the taskbar notification area.
virtual void Focus();
virtual void Focus() {}
// Popups the menu.
virtual void PopUpContextMenu(const gfx::Point& pos,
base::WeakPtr<ElectronMenuModel> menu_model);
base::WeakPtr<ElectronMenuModel> menu_model) {}
virtual void CloseContextMenu();
virtual void CloseContextMenu() {}
// Set the context menu for this icon.
virtual void SetContextMenu(raw_ptr<ElectronMenuModel> menu_model) = 0;