refactor: put empty virtual function definitions in header (#43285)
* refactor: in FramelessView, move empty function decls to header * refactor: in electron::api::WebContents, move empty function decls to header * refactor: in electron::api::NativeWindow, move empty function decls to header * refactor: in electron::OffScreenWebContentsView, move empty function decls to header * refactor: in electron::OffScreenRenderWidgetHostView, move empty function decls to header * refactor: in auto_updater::AutoUpdater, move empty function decls to header * refactor: in electorn::api::FrameSubscriber, move empty function decls to header * refactor: in electorn::api::SimpleURLLoaderWrapper, move empty function decls to header * refactor: in electorn::InspectableWebContents, move empty function decls to header * refactor: in electorn::OffScreenVideoConsumer, move empty function decls to header * refactor: in electron::OffScreenWebContentsView, move empty function decls to header * refactor: in electron::TrayIcon, move empty function decls to header * refactor: in electron::ViewsDelegate, move empty function decls to header * refactor: in electron::MediaCaptureDevicesDispatcher, move empty function decls to header * refactor: in electron::UsbChooserContext::DeviceObserver, move empty function decls to header * refactor: in electron::ProxyingWebSocket, move empty function decls to header * refactor: in electron::Notification, move empty function decls to header * refactor: in electron::PlatformNotificationService, move empty function decls to header * Revert "refactor: in electron::PlatformNotificationService, move empty function decls to header" This reverts commit 9103750d03b9ba1ceccba43d11dfdc2404ff6191. * refactor: in electron::ElectronPDFDocumentHelperClient, move empty function decls to header * refactor: in electron::api::SpellCheckClient, move empty function decls to header * refactor: in electron::ElectronExtensionHostDelegate, move empty function decls to header * refactor: in electron::PlatformNotificationService, move empty function decls to header * refactor: in electron::NativeWindowViews, move empty function decls to header * chore: move SetTouchBar() back to cc * Revert "refactor: in auto_updater::AutoUpdater, move empty function decls to header" This reverts commit c43d6862d32c74f63f82700a7546a732ac05ecb8.
This commit is contained in:
parent
bff298987f
commit
23bcca3ffc
40 changed files with 107 additions and 370 deletions
|
@ -439,46 +439,22 @@ bool NativeWindow::IsTabletMode() const {
|
|||
return false;
|
||||
}
|
||||
|
||||
void NativeWindow::SetRepresentedFilename(const std::string& filename) {}
|
||||
|
||||
std::string NativeWindow::GetRepresentedFilename() const {
|
||||
return "";
|
||||
}
|
||||
|
||||
void NativeWindow::SetDocumentEdited(bool edited) {}
|
||||
|
||||
bool NativeWindow::IsDocumentEdited() const {
|
||||
return false;
|
||||
}
|
||||
|
||||
void NativeWindow::SetFocusable(bool focusable) {}
|
||||
|
||||
bool NativeWindow::IsFocusable() const {
|
||||
return false;
|
||||
}
|
||||
|
||||
void NativeWindow::SetMenu(ElectronMenuModel* menu) {}
|
||||
|
||||
void NativeWindow::SetParentWindow(NativeWindow* parent) {
|
||||
parent_ = parent;
|
||||
}
|
||||
|
||||
void NativeWindow::InvalidateShadow() {}
|
||||
|
||||
void NativeWindow::SetAutoHideCursor(bool auto_hide) {}
|
||||
|
||||
void NativeWindow::SelectPreviousTab() {}
|
||||
|
||||
void NativeWindow::SelectNextTab() {}
|
||||
|
||||
void NativeWindow::ShowAllTabs() {}
|
||||
|
||||
void NativeWindow::MergeAllWindows() {}
|
||||
|
||||
void NativeWindow::MoveTabToNewWindow() {}
|
||||
|
||||
void NativeWindow::ToggleTabBar() {}
|
||||
|
||||
bool NativeWindow::AddTabbedWindow(NativeWindow* window) {
|
||||
return true; // for non-Mac platforms
|
||||
}
|
||||
|
@ -498,19 +474,13 @@ void NativeWindow::SetBackgroundMaterial(const std::string& type) {
|
|||
void NativeWindow::SetTouchBar(
|
||||
std::vector<gin_helper::PersistentDictionary> items) {}
|
||||
|
||||
void NativeWindow::RefreshTouchBarItem(const std::string& item_id) {}
|
||||
|
||||
void NativeWindow::SetEscapeTouchBarItem(
|
||||
gin_helper::PersistentDictionary item) {}
|
||||
|
||||
void NativeWindow::SetAutoHideMenuBar(bool auto_hide) {}
|
||||
|
||||
bool NativeWindow::IsMenuBarAutoHide() const {
|
||||
return false;
|
||||
}
|
||||
|
||||
void NativeWindow::SetMenuBarVisibility(bool visible) {}
|
||||
|
||||
bool NativeWindow::IsMenuBarVisible() const {
|
||||
return true;
|
||||
}
|
||||
|
@ -521,11 +491,6 @@ void NativeWindow::SetAspectRatio(double aspect_ratio,
|
|||
aspect_ratio_extraSize_ = extra_size;
|
||||
}
|
||||
|
||||
void NativeWindow::PreviewFile(const std::string& path,
|
||||
const std::string& display_name) {}
|
||||
|
||||
void NativeWindow::CloseFilePreview() {}
|
||||
|
||||
std::optional<gfx::Rect> NativeWindow::GetWindowControlsOverlayRect() {
|
||||
return overlay_rect_;
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue