mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: BrowserView setBackgroundColor needs two calls (#31863)

Browse source
This commit is contained in:
Shelley Vohr 2021-11-22 01:38:05 +01:00 committed by GitHub
parent 38d2ec0cb6
commit 239ba7d905
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
shell/browser/api/electron_api_browser_view.cc
View file

@ -155,11 +155,12 @@ gfx::Rect BrowserView::GetBounds() {
} }
void BrowserView::SetBackgroundColor(const std::string& color_name) { void BrowserView::SetBackgroundColor(const std::string& color_name) {
if (!web_contents()) view_->SetBackgroundColor(ParseHexColor(color_name));
return;
auto* wc = web_contents()->web_contents(); if (web_contents()) {
wc->SetPageBaseBackgroundColor(ParseHexColor(color_name)); auto* wc = web_contents()->web_contents();
wc->SetPageBaseBackgroundColor(ParseHexColor(color_name));
}
} }
v8::Local<v8::Value> BrowserView::GetWebContents(v8::Isolate* isolate) { v8::Local<v8::Value> BrowserView::GetWebContents(v8::Isolate* isolate) {