mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: crash on WebWorkerObserver script execution (#37050)

Browse source 
fix: crash on WebWorkerObserver script execution
This commit is contained in:
Shelley Vohr 2023-01-31 12:29:29 +01:00 • committed by GitHub
parent ce35bda805
commit 23739c644b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 109 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/renderer/web_worker_observer.h
View file

@ -17,8 +17,13 @@ class NodeBindings;
// Watches for WebWorker and insert node integration to it.
class WebWorkerObserver {
public:
WebWorkerObserver();
~WebWorkerObserver();
// Returns the WebWorkerObserver for current worker thread.
static WebWorkerObserver* GetCurrent();
// Creates a new WebWorkerObserver for a given context.
static WebWorkerObserver* Create();
// disable copy
WebWorkerObserver(const WebWorkerObserver&) = delete;
@ -28,9 +33,6 @@ class WebWorkerObserver {
void ContextWillDestroy(v8::Local<v8::Context> context);
private:
WebWorkerObserver();
~WebWorkerObserver();
std::unique_ptr<NodeBindings> node_bindings_;
std::unique_ptr<ElectronBindings> electron_bindings_;
};