mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Refactoring: use C++11 class member variable initialization

Browse source
This commit is contained in:
Milan Burda 2018-05-22 00:18:38 +02:00
parent ee57c95aa6
commit 2337237d58
94 changed files with 218 additions and 377 deletions
Download patch file Download diff file Expand all files Collapse all files

5
atom/renderer/atom_autofill_agent.cc
View file

@ -50,10 +50,7 @@ void TrimStringVectorForIPC(std::vector<base::string16>* strings) {
} // namespace
AutofillAgent::AutofillAgent(content::RenderFrame* frame)
: content::RenderFrameObserver(frame),
focused_node_was_last_clicked_(false),
was_focused_before_now_(false),
weak_ptr_factory_(this) {
: content::RenderFrameObserver(frame), weak_ptr_factory_(this) {
render_frame()->GetWebFrame()->SetAutofillClient(this);
}

4
atom/renderer/atom_autofill_agent.h
View file

@ -62,12 +62,12 @@ class AutofillAgent : public content::RenderFrameObserver,
void DoFocusChangeComplete();
// True when the last click was on the focused node.
bool focused_node_was_last_clicked_;
bool focused_node_was_last_clicked_ = false;
// This is set to false when the focus changes, then set back to true soon
// afterwards. This helps track whether an event happened after a node was
// already focused, or if it caused the focus to change.
bool was_focused_before_now_;
bool was_focused_before_now_ = false;
base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;

3
atom/renderer/atom_render_frame_observer.cc
View file

@ -72,8 +72,7 @@ AtomRenderFrameObserver::AtomRenderFrameObserver(
RendererClientBase* renderer_client)
: content::RenderFrameObserver(frame),
render_frame_(frame),
renderer_client_(renderer_client),
document_created_(false) {
renderer_client_(renderer_client) {
// Initialise resource for directory listing.
net::NetModule::SetResourceProvider(NetResourceProvider);
}

2
atom/renderer/atom_render_frame_observer.h
View file

@ -56,7 +56,7 @@ class AtomRenderFrameObserver : public content::RenderFrameObserver {
content::RenderFrame* render_frame_;
RendererClientBase* renderer_client_;
bool document_created_;
bool document_created_ = false;
DISALLOW_COPY_AND_ASSIGN(AtomRenderFrameObserver);
};

3
atom/renderer/atom_renderer_client.cc
View file

@ -37,8 +37,7 @@ bool IsDevToolsExtension(content::RenderFrame* render_frame) {
} // namespace
AtomRendererClient::AtomRendererClient()
: node_integration_initialized_(false),
node_bindings_(NodeBindings::Create(NodeBindings::RENDERER)),
: node_bindings_(NodeBindings::Create(NodeBindings::RENDERER)),
atom_bindings_(new AtomBindings(uv_default_loop())) {}
AtomRendererClient::~AtomRendererClient() {

2
atom/renderer/atom_renderer_client.h
View file

@ -60,7 +60,7 @@ class AtomRendererClient : public RendererClientBase {
node::Environment* GetEnvironment(content::RenderFrame* frame) const;
// Whether the node integration has been initialized.
bool node_integration_initialized_;
bool node_integration_initialized_ = false;
std::unique_ptr<NodeBindings> node_bindings_;
std::unique_ptr<AtomBindings> atom_bindings_;