remove nativeImage.createFromBuffer() deprecation

This commit is contained in:
Shelley Vohr 2018-05-23 09:43:58 -07:00
parent 94e825378c
commit 22fed0c798
No known key found for this signature in database
GPG key ID: F13993A75599653C
3 changed files with 12 additions and 13 deletions

View file

@ -517,9 +517,6 @@ mate::Handle<NativeImage> NativeImage::CreateFromBuffer(
options.Get("width", &width); options.Get("width", &width);
options.Get("height", &height); options.Get("height", &height);
options.Get("scaleFactor", &scale_factor); options.Get("scaleFactor", &scale_factor);
} else {
// TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings
args->GetNext(&scale_factor);
} }
gfx::ImageSkia image_skia; gfx::ImageSkia image_skia;

View file

@ -137,7 +137,7 @@ let image = nativeImage.createFromPath('/Users/somebody/images/icon.png')
console.log(image) console.log(image)
``` ```
### `nativeImage.createFromBuffer(buffer[, options])` ### `nativeImage.createFromBuffer(buffer, options)`
* `buffer` [Buffer][buffer] * `buffer` [Buffer][buffer]
* `options` Object (optional) * `options` Object (optional)

View file

@ -40,15 +40,6 @@ ses.setCertificateVerifyProc(function (request, callback) {
}) })
``` ```
## `webFrame`
```js
// Deprecated
webFrame.registerURLSchemeAsPrivileged('app', {secure: true})
// Replace with
protocol.registerStandardSchemes(['app'], {secure: true})
```
## Node Headers URL ## Node Headers URL
This is the URL specified as `disturl` in a `.npmrc` file or as the `--dist-url` This is the URL specified as `disturl` in a `.npmrc` file or as the `--dist-url`
@ -71,6 +62,17 @@ The following list includes the APIs that will be removed in Electron 4.0.
There is no timetable for when this release will occur but deprecation There is no timetable for when this release will occur but deprecation
warnings will be added at least [one major version](electron-versioning.md#semver) beforehand. warnings will be added at least [one major version](electron-versioning.md#semver) beforehand.
## `webFrame`
```js
// Deprecated
webFrame.registerURLSchemeAsPrivileged('app', {secure: true})
// Replace with
protocol.registerStandardSchemes(['app'], {secure: true})
```
*Nota Bene:* Before we can remove this we need to update all of the relevant specs to `protocol.registerStandardSchemes(['app'], {secure: true})`.
## `app.makeSingleInstance` ## `app.makeSingleInstance`
```js ```js