fix: unsubscribe from observers when window is closing (#25554)

2020-09-23 10:53:32 +09:00 · 2020-09-23 10:53:32 +09:00 · 22c6c891be
commit 22c6c891be
parent 29c6864ee1
3 changed files with 11 additions and 10 deletions
--- a/shell/browser/ui/cocoa/electron_ns_window_delegate.mm
+++ b/shell/browser/ui/cocoa/electron_ns_window_delegate.mm
@ -283,6 +283,7 @@ using TitleBarStyle = electron::NativeWindowMac::TitleBarStyle;
 }

 - (void)windowWillClose:(NSNotification*)notification {
+  shell_->Cleanup();
  shell_->NotifyWindowClosed();

  // Something called -[NSWindow close] on a sheet rather than calling