mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: warn if deprecated property is already set

Browse source
This commit is contained in:
Charles Kerr 2018-05-29 15:58:02 +02:00
parent 61fac1bbc1
commit 2275625e1a
2 changed files with 32 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

26
lib/common/api/deprecate.js
View file

@ -90,21 +90,27 @@ deprecate.getHandler = () => deprecationHandler
// Deprecate the old name of a property
deprecate.property = (object, deprecatedName, newName) => {
let warned = false
let warn = () => {
if (!(warned || process.noDeprecation)) {
warned = true
deprecate.warn(deprecatedName, newName)
}
}
if ((typeof object[newName] === 'undefined') &&
(typeof object[deprecatedName] !== 'undefined')) {
warn()
object[newName] = object[deprecatedName]
}
return Object.defineProperty(object, deprecatedName, {
get: function () {
let warned = false
if (!(warned || process.noDeprecation)) {
warned = true
deprecate.warn(deprecatedName, newName)
}
warn()
return this[newName]
},
set: function (value) {
let warned = false
if (!(warned || process.noDeprecation)) {
warned = true
deprecate.warn(deprecatedName, newName)
}
warn()
this[newName] = value
}
})