fix: do not initialize any extension related logic in OffTheRecord contexts (#22772)
This commit is contained in:
parent
a3ee61f963
commit
21900fe4f4
5 changed files with 115 additions and 44 deletions
54
spec-main/crash-spec.ts
Normal file
54
spec-main/crash-spec.ts
Normal file
|
@ -0,0 +1,54 @@
|
|||
import { expect } from 'chai'
|
||||
import * as cp from 'child_process'
|
||||
import * as fs from 'fs'
|
||||
import * as path from 'path'
|
||||
|
||||
const fixturePath = path.resolve(__dirname, 'fixtures', 'crash-cases')
|
||||
|
||||
let children: cp.ChildProcessWithoutNullStreams[] = []
|
||||
|
||||
const runFixtureAndEnsureCleanExit = (args: string[]) => {
|
||||
let out = ''
|
||||
const child = cp.spawn(process.execPath, args)
|
||||
children.push(child)
|
||||
child.stdout.on('data', (chunk: Buffer) => {
|
||||
out += chunk.toString()
|
||||
})
|
||||
child.stderr.on('data', (chunk: Buffer) => {
|
||||
out += chunk.toString()
|
||||
})
|
||||
return new Promise((resolve) => {
|
||||
child.on('exit', (code, signal) => {
|
||||
if (code !== 0 || signal !== null) {
|
||||
console.error(out)
|
||||
}
|
||||
expect(signal).to.equal(null, 'exit signal should be null')
|
||||
expect(code).to.equal(0, 'should have exited with code 0')
|
||||
children = children.filter(c => c !== child)
|
||||
resolve()
|
||||
})
|
||||
})
|
||||
}
|
||||
|
||||
describe('crash cases', () => {
|
||||
afterEach(() => {
|
||||
for (const child of children) {
|
||||
child.kill()
|
||||
}
|
||||
expect(children).to.have.lengthOf(0, 'all child processes should have exited cleanly')
|
||||
children.length = 0
|
||||
})
|
||||
const cases = fs.readdirSync(fixturePath)
|
||||
|
||||
for (const crashCase of cases) {
|
||||
it(`the "${crashCase}" case should not crash`, () => {
|
||||
const fixture = path.resolve(fixturePath, crashCase)
|
||||
const argsFile = path.resolve(fixture, 'electron.args')
|
||||
const args = [fixture]
|
||||
if (fs.existsSync(argsFile)) {
|
||||
args.push(...fs.readFileSync(argsFile, 'utf8').trim().split('\n'))
|
||||
}
|
||||
return runFixtureAndEnsureCleanExit(args)
|
||||
})
|
||||
}
|
||||
})
|
Loading…
Add table
Add a link
Reference in a new issue