mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

remove setZoomLevelLimits

Browse source
This commit is contained in:
Shelley Vohr 2018-02-20 08:57:48 -05:00
parent 459a5e3a1f
commit 211b542ae4
No known key found for this signature in database
GPG key ID: F13993A75599653C
6 changed files with 3 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
atom/renderer/api/atom_api_web_frame.cc
View file

@ -407,9 +407,7 @@ void WebFrame::BuildPrototype(
.SetMethod("setIsolatedWorldHumanReadableName", .SetMethod("setIsolatedWorldHumanReadableName",
&WebFrame::SetIsolatedWorldHumanReadableName) &WebFrame::SetIsolatedWorldHumanReadableName)
.SetMethod("getResourceUsage", &WebFrame::GetResourceUsage) .SetMethod("getResourceUsage", &WebFrame::GetResourceUsage)
.SetMethod("clearCache", &WebFrame::ClearCache) .SetMethod("clearCache", &WebFrame::ClearCache);
// TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings
.SetMethod("setZoomLevelLimits", &WebFrame::SetVisualZoomLevelLimits);
} }
} // namespace api } // namespace api

8
docs/api/web-contents.md
View file

@ -842,14 +842,6 @@ limits of 300% and 50% of original size, respectively. The formula for this is
Sends a request to get current zoom level, the `callback` will be called with Sends a request to get current zoom level, the `callback` will be called with
`callback(zoomLevel)`. `callback(zoomLevel)`.
#### `contents.setZoomLevelLimits(minimumLevel, maximumLevel)`
* `minimumLevel` Number
* `maximumLevel` Number
**Deprecated:** Call `setVisualZoomLevelLimits` instead to set the visual zoom
level limits. This method will be removed in Electron 2.0.
#### `contents.setVisualZoomLevelLimits(minimumLevel, maximumLevel)` #### `contents.setVisualZoomLevelLimits(minimumLevel, maximumLevel)`
* `minimumLevel` Number * `minimumLevel` Number

8
docs/api/web-frame.md
View file

@ -39,14 +39,6 @@ limits of 300% and 50% of original size, respectively.
Returns `Number` - The current zoom level. Returns `Number` - The current zoom level.
### `webFrame.setZoomLevelLimits(minimumLevel, maximumLevel)`
* `minimumLevel` Number
* `maximumLevel` Number
**Deprecated:** Call `setVisualZoomLevelLimits` instead to set the visual zoom
level limits. This method will be removed in Electron 2.0.
### `webFrame.setVisualZoomLevelLimits(minimumLevel, maximumLevel)` ### `webFrame.setVisualZoomLevelLimits(minimumLevel, maximumLevel)`
* `minimumLevel` Number * `minimumLevel` Number

4
lib/browser/api/web-contents.js
View file

@ -109,9 +109,7 @@ const webFrameMethods = [
'insertCSS', 'insertCSS',
'insertText', 'insertText',
'setLayoutZoomLevelLimits', 'setLayoutZoomLevelLimits',
'setVisualZoomLevelLimits', 'setVisualZoomLevelLimits'
// TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings
'setZoomLevelLimits'
] ]
const webFrameMethodsWithResult = [] const webFrameMethodsWithResult = []

4
lib/renderer/web-view/web-view.js
View file

@ -375,9 +375,7 @@ const registerWebViewElement = function () {
'send', 'send',
'sendInputEvent', 'sendInputEvent',
'setLayoutZoomLevelLimits', 'setLayoutZoomLevelLimits',
'setVisualZoomLevelLimits', 'setVisualZoomLevelLimits'
// TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings
'setZoomLevelLimits'
] ]
// Forward proto.foo* method calls to WebViewImpl.foo*. // Forward proto.foo* method calls to WebViewImpl.foo*.

1
spec/api-web-frame-spec.js
View file

@ -134,7 +134,6 @@ describe('webFrame module', function () {
it('supports setting the visual and layout zoom level limits', function () { it('supports setting the visual and layout zoom level limits', function () {
assert.doesNotThrow(function () { assert.doesNotThrow(function () {
webFrame.setZoomLevelLimits(1, 100)
webFrame.setVisualZoomLevelLimits(1, 50) webFrame.setVisualZoomLevelLimits(1, 50)
webFrame.setLayoutZoomLevelLimits(0, 25) webFrame.setLayoutZoomLevelLimits(0, 25)
}) })