mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not append "Renderer" in product name when uploading.

Browse source
This commit is contained in:
Cheng Zhao 2013-11-19 12:19:23 +08:00
parent ed3358e501
commit 20e368eb89
4 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
common/crash_reporter/crash_reporter.cc
View file

@ -19,7 +19,7 @@ CrashReporter::CrashReporter() {
CrashReporter::~CrashReporter() { CrashReporter::~CrashReporter() {
} }
void CrashReporter::Start(std::string product_name, void CrashReporter::Start(const std::string& product_name,
const std::string& company_name, const std::string& company_name,
const std::string& submit_url, const std::string& submit_url,
bool auto_submit, bool auto_submit,
@ -27,8 +27,6 @@ void CrashReporter::Start(std::string product_name,
const StringMap& extra_parameters) { const StringMap& extra_parameters) {
SetUploadParameters(extra_parameters); SetUploadParameters(extra_parameters);
// Append "Renderer" for the renderer.
product_name += " Renderer";
InitBreakpad(product_name, ATOM_VERSION_STRING, company_name, submit_url, InitBreakpad(product_name, ATOM_VERSION_STRING, company_name, submit_url,
auto_submit, skip_system_crash_handler); auto_submit, skip_system_crash_handler);
} }

2
common/crash_reporter/crash_reporter.h
View file

@ -18,7 +18,7 @@ class CrashReporter {
static CrashReporter* GetInstance(); static CrashReporter* GetInstance();
void Start(std::string product_name, void Start(const std::string& product_name,
const std::string& company_name, const std::string& company_name,
const std::string& submit_url, const std::string& submit_url,
bool auto_submit, bool auto_submit,

5
common/crash_reporter/crash_reporter_mac.mm
View file

@ -28,11 +28,16 @@ void CrashReporterMac::InitBreakpad(const std::string& product_name,
if (breakpad_ != NULL) if (breakpad_ != NULL)
BreakpadRelease(breakpad_); BreakpadRelease(breakpad_);
std::string display_name = is_browser_ ? product_name :
product_name + " Renderer";
NSMutableDictionary* parameters = NSMutableDictionary* parameters =
[NSMutableDictionary dictionaryWithCapacity:4]; [NSMutableDictionary dictionaryWithCapacity:4];
[parameters setValue:base::SysUTF8ToNSString(product_name) [parameters setValue:base::SysUTF8ToNSString(product_name)
forKey:@BREAKPAD_PRODUCT]; forKey:@BREAKPAD_PRODUCT];
[parameters setValue:base::SysUTF8ToNSString(product_name)
forKey:@BREAKPAD_PRODUCT_DISPLAY];
[parameters setValue:base::SysUTF8ToNSString(version) [parameters setValue:base::SysUTF8ToNSString(version)
forKey:@BREAKPAD_VERSION]; forKey:@BREAKPAD_VERSION];
[parameters setValue:base::SysUTF8ToNSString(company_name) [parameters setValue:base::SysUTF8ToNSString(company_name)

2
spec/api/crash-reporter.coffee
View file

@ -13,7 +13,7 @@ describe 'crash-reporter module', ->
server = http.createServer (req, res) -> server = http.createServer (req, res) ->
form = new formidable.IncomingForm() form = new formidable.IncomingForm()
form.parse req, (error, fields, files) -> form.parse req, (error, fields, files) ->
assert.equal fields['prod'], 'Atom-Shell Renderer' assert.equal fields['prod'], 'Atom-Shell'
assert.equal fields['ver'], process.versions['atom-shell'] assert.equal fields['ver'], process.versions['atom-shell']
assert.equal fields['process_type'], 'renderer' assert.equal fields['process_type'], 'renderer'
assert.equal fields['platform'], process.platform assert.equal fields['platform'], process.platform