mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: improve renderer crash logging (#25592)

Browse source
This commit is contained in:
Milan Burda 2020-09-24 17:22:17 +02:00 • committed by GitHub
parent dcd6e1f2b8
commit 1f856c25a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/browser/api/web-contents.ts
View file

@ -462,8 +462,7 @@ const addReturnValueToEvent = (event: any) => {
}; };
const loggingEnabled = () => { const loggingEnabled = () => {
return Object.prototype.hasOwnProperty.call(process.env, 'ELECTRON_ENABLE_LOGGING') || return process.env.ELECTRON_ENABLE_LOGGING || app.commandLine.hasSwitch('enable-logging');
process.argv.some(arg => arg.toLowerCase().startsWith('--enable-logging'));
}; };
// Add JavaScript wrappers for WebContents class. // Add JavaScript wrappers for WebContents class.
@ -548,17 +547,17 @@ WebContents.prototype._init = function () {
this.on('crashed', (event, ...args) => { this.on('crashed', (event, ...args) => {
app.emit('renderer-process-crashed', event, this, ...args); app.emit('renderer-process-crashed', event, this, ...args);
});
this.on('render-process-gone', (event, details) => {
app.emit('render-process-gone', event, this, details);
// Log out a hint to help users better debug renderer crashes. // Log out a hint to help users better debug renderer crashes.
if (loggingEnabled()) { if (loggingEnabled()) {
console.info('Renderer process crashed - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.'); console.info(`Renderer process ${details.reason} - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.`);
} }
}); });
this.on('render-process-gone', (event, ...args) => {
app.emit('render-process-gone', event, this, ...args);
});
// The devtools requests the webContents to reload. // The devtools requests the webContents to reload.
this.on('devtools-reload-page', function (this: Electron.WebContentsInternal) { this.on('devtools-reload-page', function (this: Electron.WebContentsInternal) {
this.reload(); this.reload();