mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

style: no need for done call in sync tests (#15550)

Browse source
This commit is contained in:
Heilig Benedek 2018-11-02 15:50:17 +01:00 committed by John Kleinschmidt
parent 6e6ab9b907
commit 1f5e0c42f3
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
spec/api-menu-item-spec.js
View file

@ -395,7 +395,7 @@ describe('MenuItems', () => {
return (process.platform === 'darwin') return (process.platform === 'darwin')
} }
it('should display modifiers correctly for simple keys', done => { it('should display modifiers correctly for simple keys', () => {
const menu = Menu.buildFromTemplate([ const menu = Menu.buildFromTemplate([
{ label: 'text', accelerator: 'CmdOrCtrl+A' }, { label: 'text', accelerator: 'CmdOrCtrl+A' },
{ label: 'text', accelerator: 'Shift+A' }, { label: 'text', accelerator: 'Shift+A' },
@ -408,10 +408,9 @@ describe('MenuItems', () => {
isDarwin() ? '⇧A' : 'Shift+A') isDarwin() ? '⇧A' : 'Shift+A')
assert.strictEqual(menu.getAcceleratorTextAt(2), assert.strictEqual(menu.getAcceleratorTextAt(2),
isDarwin() ? '⌥A' : 'Alt+A') isDarwin() ? '⌥A' : 'Alt+A')
done()
}) })
it('should display modifiers correctly for special keys', done => { it('should display modifiers correctly for special keys', () => {
const menu = Menu.buildFromTemplate([ const menu = Menu.buildFromTemplate([
{ label: 'text', accelerator: 'CmdOrCtrl+Tab' }, { label: 'text', accelerator: 'CmdOrCtrl+Tab' },
{ label: 'text', accelerator: 'Shift+Tab' }, { label: 'text', accelerator: 'Shift+Tab' },
@ -424,10 +423,9 @@ describe('MenuItems', () => {
isDarwin() ? '⇧⇥\u0000' : 'Shift+Tab') isDarwin() ? '⇧⇥\u0000' : 'Shift+Tab')
assert.strictEqual(menu.getAcceleratorTextAt(2), assert.strictEqual(menu.getAcceleratorTextAt(2),
isDarwin() ? '⌥⇥\u0000' : 'Alt+Tab') isDarwin() ? '⌥⇥\u0000' : 'Alt+Tab')
done()
}) })
it('should not display modifiers twice', done => { it('should not display modifiers twice', () => {
const menu = Menu.buildFromTemplate([ const menu = Menu.buildFromTemplate([
{ label: 'text', accelerator: 'Shift+Shift+A' }, { label: 'text', accelerator: 'Shift+Shift+A' },
{ label: 'text', accelerator: 'Shift+Shift+Tab' } { label: 'text', accelerator: 'Shift+Shift+Tab' }
@ -437,10 +435,9 @@ describe('MenuItems', () => {
isDarwin() ? '⇧A' : 'Shift+A') isDarwin() ? '⇧A' : 'Shift+A')
assert.strictEqual(menu.getAcceleratorTextAt(1), assert.strictEqual(menu.getAcceleratorTextAt(1),
isDarwin() ? '⇧⇥\u0000' : 'Shift+Tab') isDarwin() ? '⇧⇥\u0000' : 'Shift+Tab')
done()
}) })
it('should display correctly for edge cases', done => { it('should display correctly for edge cases', () => {
const menu = Menu.buildFromTemplate([ const menu = Menu.buildFromTemplate([
{ label: 'text', accelerator: 'Control+Shift+=' }, { label: 'text', accelerator: 'Control+Shift+=' },
{ label: 'text', accelerator: 'Control+Plus' } { label: 'text', accelerator: 'Control+Plus' }
@ -450,7 +447,6 @@ describe('MenuItems', () => {
isDarwin() ? '⌃⇧=' : 'Ctrl+Shift+=') isDarwin() ? '⌃⇧=' : 'Ctrl+Shift+=')
assert.strictEqual(menu.getAcceleratorTextAt(1), assert.strictEqual(menu.getAcceleratorTextAt(1),
isDarwin() ? '⌃⇧=' : 'Ctrl+Shift+=') isDarwin() ? '⌃⇧=' : 'Ctrl+Shift+=')
done()
}) })
}) })
}) })