mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: promisify protocol.isProtocolHandled() (#16423)

Browse source 
* feat: promisify protocol

* fix base::Bind and specs

* update documentation

* make callback-compatible

* async awaitify tests
This commit is contained in:
Shelley Vohr 2019-01-17 09:05:10 -08:00 • committed by GitHub
parent 32d98851bc
commit 1f2b02c18f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 65 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

14
spec/api-session-spec.js
View file

@ -524,14 +524,12 @@ describe('session module', () => {
partitionProtocol.unregisterProtocol(protocolName, () => done())
})
it('does not affect defaultSession', (done) => {
protocol.isProtocolHandled(protocolName, (result) => {
assert.strictEqual(result, false)
partitionProtocol.isProtocolHandled(protocolName, (result) => {
assert.strictEqual(result, true)
done()
})
})
it('does not affect defaultSession', async () => {
const result1 = await protocol.isProtocolHandled(protocolName)
assert.strictEqual(result1, false)
const result2 = await partitionProtocol.isProtocolHandled(protocolName)
assert.strictEqual(result2, true)
})
it('handles requests from partition', (done) => {