mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

refactor: remove stray .c_str() calls for absl::StrFormat() (#47577)

Browse source 
refactor: remove stray .c_str() calls for absl::StrFormat()

StrFormat() understands std::string, std::string_view

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-06-26 08:18:06 -05:00 • committed by GitHub
commit 1eb8f7e705
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 27 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

21
shell/browser/ui/inspectable_web_contents.cc
View file

@ -139,16 +139,14 @@ double GetNextZoomLevel(double level, bool out) {
}
GURL GetRemoteBaseURL() {
return GURL(
absl::StrFormat("%s%s/%s/", kChromeUIDevToolsRemoteFrontendBase,
kChromeUIDevToolsRemoteFrontendPath,
embedder_support::GetChromiumGitRevision().c_str()));
return GURL(absl::StrFormat("%s%s/%s/", kChromeUIDevToolsRemoteFrontendBase,
kChromeUIDevToolsRemoteFrontendPath,
embedder_support::GetChromiumGitRevision()));
}
GURL GetDevToolsURL(bool can_dock) {
auto url_string =
absl::StrFormat(kChromeUIDevToolsURL, GetRemoteBaseURL().spec().c_str(),
can_dock ? "true" : "");
auto url_string = absl::StrFormat(
kChromeUIDevToolsURL, GetRemoteBaseURL().spec(), can_dock ? "true" : "");
return GURL(url_string);
}
@ -630,8 +628,7 @@ void InspectableWebContents::SetInspectedPageBounds(const gfx::Rect& rect) {
void InspectableWebContents::InspectedURLChanged(const std::string& url) {
if (managed_devtools_web_contents_) {
if (devtools_title_.empty()) {
view_->SetTitle(
base::UTF8ToUTF16(absl::StrFormat(kTitleFormat, url.c_str())));
view_->SetTitle(base::UTF8ToUTF16(absl::StrFormat(kTitleFormat, url)));
}
}
}
@ -1023,9 +1020,9 @@ void InspectableWebContents::DidFinishNavigation(
// most likely bug in chromium.
base::ReplaceFirstSubstringAfterOffset(&it->second, 0, "var chrome",
"var chrome = window.chrome ");
auto script = absl::StrFormat(
"%s(\"%s\")", it->second.c_str(),
base::Uuid::GenerateRandomV4().AsLowercaseString().c_str());
auto script =
absl::StrFormat("%s(\"%s\")", it->second,
base::Uuid::GenerateRandomV4().AsLowercaseString());
// Invoking content::DevToolsFrontendHost::SetupExtensionsAPI(frame, script);
// should be enough, but it seems to be a noop currently.
frame->ExecuteJavaScriptForTests(base::UTF8ToUTF16(script),