From 1df033dce848f2de1c99e7e078cf0ad647eeb6b8 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Fri, 20 Mar 2015 19:04:11 +0800 Subject: [PATCH] No need to override child_process.fork We already support asar in Node mode. --- atom/common/lib/asar.coffee | 1 - spec/asar-spec.coffee | 5 ----- 2 files changed, 6 deletions(-) diff --git a/atom/common/lib/asar.coffee b/atom/common/lib/asar.coffee index 38ac2fc3b727..e3e0f6f29899 100644 --- a/atom/common/lib/asar.coffee +++ b/atom/common/lib/asar.coffee @@ -298,4 +298,3 @@ exports.wrapFsWithAsar = (fs) -> overrideAPISync process, 'dlopen', 1 overrideAPISync require('module')._extensions, '.node', 1 overrideAPISync fs, 'openSync' - overrideAPISync child_process, 'fork' diff --git a/spec/asar-spec.coffee b/spec/asar-spec.coffee index 222faf9a5e2e..39aa1e6ebe8b 100644 --- a/spec/asar-spec.coffee +++ b/spec/asar-spec.coffee @@ -342,11 +342,6 @@ describe 'asar package', -> done() child.send 'message' - it 'throws ENOENT error when can not find file', -> - p = path.join fixtures, 'asar', 'a.asar', 'not-exist' - throws = -> child_process.fork p - assert.throws throws, /ENOENT/ - it 'supports asar in the forked js', (done) -> file = path.join fixtures, 'asar', 'a.asar', 'file1' child = child_process.fork path.join(fixtures, 'module', 'asar.js')