mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't resolve empty src/preload attribute values

Browse source
This commit is contained in:
Kevin Sawicki 2016-09-08 16:48:30 -07:00
parent ea069805d1
commit 1dbaf4987e
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/renderer/web-view/web-view-attributes.js
View file

@ -9,6 +9,7 @@ const remote = require('electron').remote
var a = document.createElement('a') var a = document.createElement('a')
var resolveURL = function (url) { var resolveURL = function (url) {
if (url === '') return ''
a.href = url a.href = url
return a.href return a.href
} }

8
spec/webview-spec.js
View file

@ -80,6 +80,10 @@ describe('<webview> tag', function () {
assert.equal(webview.src, '') assert.equal(webview.src, '')
webview.src = '' webview.src = ''
assert.equal(webview.src, '') assert.equal(webview.src, '')
webview.src = null
assert.equal(webview.src, '')
webview.src = undefined
assert.equal(webview.src, '')
}) })
}) })
@ -209,6 +213,10 @@ describe('<webview> tag', function () {
assert.equal(webview.preload, '') assert.equal(webview.preload, '')
webview.preload = '' webview.preload = ''
assert.equal(webview.preload, '') assert.equal(webview.preload, '')
webview.preload = null
assert.equal(webview.preload, '')
webview.preload = undefined
assert.equal(webview.preload, '')
}) })
}) })