From 4ded709307e0406afa04e2636104818dc45747a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Machist=C3=A9=20N=2E=20Quintana?= Date: Mon, 7 Mar 2016 15:42:32 -0800 Subject: [PATCH 1/4] Map selectors for delete and pasteAndMatchStyle to roles --- atom/browser/ui/cocoa/atom_menu_controller.mm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/atom/browser/ui/cocoa/atom_menu_controller.mm b/atom/browser/ui/cocoa/atom_menu_controller.mm index 9c8c99da9aa..6761c51704f 100644 --- a/atom/browser/ui/cocoa/atom_menu_controller.mm +++ b/atom/browser/ui/cocoa/atom_menu_controller.mm @@ -32,6 +32,8 @@ Role kRolesMap[] = { { @selector(cut:), "cut" }, { @selector(copy:), "copy" }, { @selector(paste:), "paste" }, + { @selector(delete:), "delete"}, + { @selector(pasteAndMatchStyle:), "paste-and-match-style" }, { @selector(selectAll:), "selectall" }, { @selector(performMiniaturize:), "minimize" }, { @selector(performClose:), "close" }, From 03434f45bb7cca242bf196857fcff077d1d0c33f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Machist=C3=A9=20N=2E=20Quintana?= Date: Mon, 7 Mar 2016 15:50:33 -0800 Subject: [PATCH 2/4] Map webContents.delete to role --- atom/browser/api/lib/menu-item.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/atom/browser/api/lib/menu-item.js b/atom/browser/api/lib/menu-item.js index eef8881cf52..4f449ecc015 100644 --- a/atom/browser/api/lib/menu-item.js +++ b/atom/browser/api/lib/menu-item.js @@ -11,7 +11,8 @@ rolesMap = { paste: 'paste', selectall: 'selectAll', minimize: 'minimize', - close: 'close' + close: 'close', + delete: 'delete' }; // Maps methods that should be called directly on the BrowserWindow instance From eae5cc9d2c6da51e239be43053b350b8d2b5d0b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Machist=C3=A9=20N=2E=20Quintana?= Date: Mon, 7 Mar 2016 15:53:09 -0800 Subject: [PATCH 3/4] :art: [ci skip] --- atom/browser/ui/cocoa/atom_menu_controller.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atom/browser/ui/cocoa/atom_menu_controller.mm b/atom/browser/ui/cocoa/atom_menu_controller.mm index 6761c51704f..0754da0cf5e 100644 --- a/atom/browser/ui/cocoa/atom_menu_controller.mm +++ b/atom/browser/ui/cocoa/atom_menu_controller.mm @@ -32,7 +32,7 @@ Role kRolesMap[] = { { @selector(cut:), "cut" }, { @selector(copy:), "copy" }, { @selector(paste:), "paste" }, - { @selector(delete:), "delete"}, + { @selector(delete:), "delete" }, { @selector(pasteAndMatchStyle:), "paste-and-match-style" }, { @selector(selectAll:), "selectall" }, { @selector(performMiniaturize:), "minimize" }, From 2bfc7aa152ec7466b0d151bf5ab93efd016ff8ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Machist=C3=A9=20N=2E=20Quintana?= Date: Mon, 7 Mar 2016 16:01:46 -0800 Subject: [PATCH 4/4] Add mapping for performZoom --- atom/browser/ui/cocoa/atom_menu_controller.mm | 1 + 1 file changed, 1 insertion(+) diff --git a/atom/browser/ui/cocoa/atom_menu_controller.mm b/atom/browser/ui/cocoa/atom_menu_controller.mm index 0754da0cf5e..24098914b7c 100644 --- a/atom/browser/ui/cocoa/atom_menu_controller.mm +++ b/atom/browser/ui/cocoa/atom_menu_controller.mm @@ -37,6 +37,7 @@ Role kRolesMap[] = { { @selector(selectAll:), "selectall" }, { @selector(performMiniaturize:), "minimize" }, { @selector(performClose:), "close" }, + { @selector(performZoom:), "zoom" }, }; } // namespace