mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

app.setBadgeCount should return boolean

Browse source
This commit is contained in:
Cheng Zhao 2016-07-01 22:18:39 +09:00
parent f8ec377123
commit 1da2a1c2ae
6 changed files with 24 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/browser.h
View file

@ -88,7 +88,7 @@ class Browser : public WindowListObserver {
bool IsDefaultProtocolClient(const std::string& protocol);
// Set/Get the badge count.
void SetBadgeCount(int count);
bool SetBadgeCount(int count);
int GetBadgeCount();
#if defined(OS_MACOSX)

11
atom/browser/browser_linux.cc
View file

@ -47,9 +47,14 @@ bool Browser::IsDefaultProtocolClient(const std::string& protocol) {
return false;
}
void Browser::SetBadgeCount(int count) {
current_badge_count_ = count;
unity::SetDownloadCount(count);
bool Browser::SetBadgeCount(int count) {
if (IsUnityRunning()) {
unity::SetDownloadCount(count);
current_badge_count_ = count;
return true;
} else {
return false;
}
}
std::string Browser::GetExecutableFileVersion() const {

5
atom/browser/browser_mac.mm
View file

@ -115,9 +115,10 @@ bool Browser::IsDefaultProtocolClient(const std::string& protocol) {
void Browser::SetAppUserModelID(const base::string16& name) {
}
void Browser::SetBadgeCount(int count) {
bool Browser::SetBadgeCount(int count) {
DockSetBadgeText(count != 0 ? base::IntToString(count) : "");
current_badge_count_ = count;
DockSetBadgeText(count == 0 ? base::IntToString(count) : "");
return true;
}
void Browser::SetUserActivity(const std::string& type,

4
atom/browser/browser_win.cc
View file

@ -269,8 +269,8 @@ bool Browser::IsDefaultProtocolClient(const std::string& protocol) {
}
}
void Browser::SetBadgeCount(int count) {
current_badge_count_ = count;
bool Browser::SetBadgeCount(int count) {
return false;
}
PCWSTR Browser::GetAppUserModelID() {