mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

FIXME: refactor and remove usage of ScopedAllowIO where possible

Browse source
This commit is contained in:
deepak1556 2017-12-10 22:58:06 +05:30 • committed by Cheng Zhao
parent 90acb22a58
commit 1d95241185
3 changed files with 36 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/common/api/atom_api_native_image.cc
View file

@ -15,6 +15,7 @@
#include "base/files/file_util.h"
#include "base/strings/pattern.h"
#include "base/strings/string_util.h"
#include "base/threading/thread_restrictions.h"
#include "native_mate/object_template_builder.h"
#include "net/base/data_url.h"
#include "third_party/skia/include/core/SkBitmap.h"
@ -130,8 +131,11 @@ bool AddImageSkiaRep(gfx::ImageSkia* image,
const base::FilePath& path,
double scale_factor) {
std::string file_contents;
if (!asar::ReadFileToString(path, &file_contents))
return false;
{
base::ThreadRestrictions::ScopedAllowIO allow_io;
if (!asar::ReadFileToString(path, &file_contents))
return false;
}
const unsigned char* data =
reinterpret_cast<const unsigned char*>(file_contents.data());