mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

remove deprecated tests

Browse source
This commit is contained in:
Shelley Vohr 2017-11-02 00:16:51 -04:00
parent 65f125a245
commit 1d6803b234
No known key found for this signature in database
GPG key ID: F13993A75599653C
1 changed files with 2 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

33
spec/api-crash-reporter-spec.js
View file

@ -328,20 +328,7 @@ describe('crashReporter module', () => {
const parameters = crashReporter.getParameters() const parameters = crashReporter.getParameters()
assert(typeof parameters === 'object') assert(typeof parameters === 'object')
}) })
// TODO(2.0) Remove it('adds a parameter to current parameters', () => {
it('adds a parameter with setExtraParameter', () => {
// only run on MacOS
if (process.platform !== 'darwin') return
crashReporter.start({
companyName: 'Umbrella Corporation',
submitURL: 'http://127.0.0.1/crashes'
})
crashReporter.setExtraParameter('hello', 'world')
assert('hello' in crashReporter.getParameters())
})
it('adds a parameter with addExtraParameter', () => {
// only run on MacOS // only run on MacOS
if (process.platform !== 'darwin') return if (process.platform !== 'darwin') return
@ -353,23 +340,7 @@ describe('crashReporter module', () => {
crashReporter.addExtraParameter('hello', 'world') crashReporter.addExtraParameter('hello', 'world')
assert('hello' in crashReporter.getParameters()) assert('hello' in crashReporter.getParameters())
}) })
// TODO(2.0) Remove it('removes a parameter from current parameters', () => {
it('removes a parameter with setExtraParameter', () => {
// only run on MacOS
if (process.platform !== 'darwin') return
crashReporter.start({
companyName: 'Umbrella Corporation',
submitURL: 'http://127.0.0.1/crashes'
})
crashReporter.setExtraParameter('hello', 'world')
assert('hello' in crashReporter.getParameters())
crashReporter.setExtraParameter('hello')
assert(!('hello' in crashReporter.getParameters()))
})
it('removes a parameter with removeExtraParameter', () => {
// only run on MacOS // only run on MacOS
if (process.platform !== 'darwin') return if (process.platform !== 'darwin') return