Merge pull request #9991 from electron/surface-runas-require-errors

Surface require errors via answer IPC message
2017-07-13 08:55:06 -07:00 · 2017-07-13 08:55:06 -07:00 · 1d32f300f3
commit 1d32f300f3
parent 30df0f3306 60f563ae5f
1 changed files with 15 additions and 2 deletions
--- a/spec/fixtures/api/native-window-open-native-addon.html
+++ b/spec/fixtures/api/native-window-open-native-addon.html
@ -2,8 +2,21 @@
 <body>
 <script type="text/javascript" charset="utf-8">
  const {ipcRenderer} = require('electron')
-  const runas = require('runas')
-  ipcRenderer.send('answer', typeof runas)
+
+  let runas
+  let requireError
+
+  try {
+    runas = require('runas')
+  } catch (error) {
+    requireError = error
+  }
+
+  if (requireError != null) {
+    ipcRenderer.send('answer', `Require runas failed: ${requireError.message}`)
+  } else {
+    ipcRenderer.send('answer', typeof runas)
+  }
 </script>
 </body>
 </html>