From 864449db89b509154f99c2f0854e95f45ffbc373 Mon Sep 17 00:00:00 2001 From: Paul P Date: Tue, 26 Jan 2016 14:44:46 +0000 Subject: [PATCH 1/2] prevent assignment to constant variable (url) --- atom/browser/api/lib/auto-updater/auto-updater-win.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/atom/browser/api/lib/auto-updater/auto-updater-win.js b/atom/browser/api/lib/auto-updater/auto-updater-win.js index e7d6daca9273..4c3edd3dcd2b 100644 --- a/atom/browser/api/lib/auto-updater/auto-updater-win.js +++ b/atom/browser/api/lib/auto-updater/auto-updater-win.js @@ -45,8 +45,7 @@ class AutoUpdater extends EventEmitter { // Following information is not available on Windows, so fake them. date = new Date; - url = _this.updateURL; - return _this.emit('update-downloaded', {}, releaseNotes, version, date, url, function() { + return _this.emit('update-downloaded', {}, releaseNotes, version, date, _this.updateURL, function() { return _this.quitAndInstall(); }); }); From cbf11f38ca35832500064bf40964b8b9158f0e07 Mon Sep 17 00:00:00 2001 From: Paul P Date: Tue, 26 Jan 2016 14:55:31 +0000 Subject: [PATCH 2/2] remove unused variable --- atom/browser/api/lib/auto-updater/auto-updater-win.js | 1 - 1 file changed, 1 deletion(-) diff --git a/atom/browser/api/lib/auto-updater/auto-updater-win.js b/atom/browser/api/lib/auto-updater/auto-updater-win.js index 4c3edd3dcd2b..f8a07902f212 100644 --- a/atom/browser/api/lib/auto-updater/auto-updater-win.js +++ b/atom/browser/api/lib/auto-updater/auto-updater-win.js @@ -2,7 +2,6 @@ const app = require('electron').app; const EventEmitter = require('events').EventEmitter; -const url = require('url'); const squirrelUpdate = require('./squirrel-update-win'); class AutoUpdater extends EventEmitter {