mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2712 from etiktin/add_chrome_version_2_gitignore

Browse source 
Fix `create_chrome_version_h` so it will generate chrome_version.h only if needed
This commit is contained in:
Cheng Zhao 2015-09-08 13:24:12 +08:00
commit 1ca6534dcd
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
script/bootstrap.py
View file

@ -162,13 +162,16 @@ def create_chrome_version_h():
version = f.read() version = f.read()
with open(template_file, 'r') as f: with open(template_file, 'r') as f:
template = f.read() template = f.read()
if sys.platform in ['win32', 'cygwin']:
open_mode = 'wb+'
else:
open_mode = 'w+'
with open(target_file, open_mode) as f:
content = template.replace('{PLACEHOLDER}', version.strip()) content = template.replace('{PLACEHOLDER}', version.strip())
if f.read() != content:
# We update the file only if the content has changed (ignoring line ending
# differences).
should_write = True
if os.path.isfile(target_file):
with open(target_file, 'r') as f:
should_write = f.read().replace('r', '') != content.replace('r', '')
if should_write:
with open(target_file, 'w') as f:
f.write(content) f.write(content)