mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: return path from netLog.stopLogging (#21985)

Browse source
This commit is contained in:
Jeremy Apthorp 2020-01-31 10:43:02 -08:00 • committed by GitHub
parent a58bc42ed0
commit 1c6d8f5af6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/browser/api/session.js
View file

@ -36,8 +36,9 @@ NetLog.prototype.startLogging = function (path, ...args) {
const _originalStopLogging = NetLog.prototype.stopLogging const _originalStopLogging = NetLog.prototype.stopLogging
NetLog.prototype.stopLogging = function () { NetLog.prototype.stopLogging = function () {
const logPath = this._currentlyLoggingPath
this._currentlyLoggingPath = null this._currentlyLoggingPath = null
return _originalStopLogging.call(this) return _originalStopLogging.call(this).then(() => logPath)
} }
const currentlyLoggingPathDeprecated = deprecate.warnOnce('currentlyLoggingPath') const currentlyLoggingPathDeprecated = deprecate.warnOnce('currentlyLoggingPath')

3
spec-main/api-net-log-spec.ts
View file

@ -71,7 +71,8 @@ describe('netLog module', () => {
expect(testNetLog().currentlyLoggingPath).to.equal(dumpFileDynamic) expect(testNetLog().currentlyLoggingPath).to.equal(dumpFileDynamic)
await testNetLog().stopLogging() const path = await testNetLog().stopLogging()
expect(path).to.equal(dumpFileDynamic)
expect(fs.existsSync(dumpFileDynamic)).to.be.true('currently logging') expect(fs.existsSync(dumpFileDynamic)).to.be.true('currently logging')
}) })