mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: use delay() helper (#24321)

Browse source
This commit is contained in:
Milan Burda 2020-06-26 22:59:54 +02:00 • committed by GitHub
parent 8eb198bab4
commit 1c49e4e376
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 24 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

17
spec-main/api-browser-window-spec.ts
View file

@ -9,7 +9,7 @@ import { AddressInfo } from 'net';
import { app, BrowserWindow, BrowserView, ipcMain, OnBeforeSendHeadersListenerDetails, protocol, screen, webContents, session, WebContents } from 'electron/main';
import { emittedOnce, emittedUntil } from './events-helpers';
import { ifit, ifdescribe } from './spec-helpers';
import { ifit, ifdescribe, delay } from './spec-helpers';
import { closeWindow, closeAllWindows } from './window-helpers';
const features = process._linkedBinding('electron_common_features');
@ -3145,7 +3145,7 @@ describe('BrowserWindow module', () => {
await w.webContents.executeJavaScript('document.body.webkitRequestFullscreen()', true);
await emittedOnce(w, 'enter-full-screen');
// Wait a tick for the full-screen state to 'stick'
await new Promise(resolve => setTimeout(resolve));
await delay();
w.setFullScreen(false);
await emittedOnce(w, 'leave-html-full-screen');
});
@ -3786,7 +3786,6 @@ describe('BrowserWindow module', () => {
});
// fullscreen events are dispatched eagerly and twiddling things too fast can confuse poor Electron
const tick = () => new Promise(resolve => setTimeout(resolve));
ifdescribe(process.platform === 'darwin')('kiosk state', () => {
it('with properties', () => {
@ -3798,7 +3797,7 @@ describe('BrowserWindow module', () => {
it('can be changed ', (done) => {
const w = new BrowserWindow();
w.once('enter-full-screen', async () => {
await tick();
await delay();
w.kiosk = false;
expect(w.kiosk).to.be.false();
});
@ -3819,7 +3818,7 @@ describe('BrowserWindow module', () => {
it('can be changed ', (done) => {
const w = new BrowserWindow();
w.once('enter-full-screen', async () => {
await tick();
await delay();
w.setKiosk(false);
expect(w.isKiosk()).to.be.false('isKiosk');
});
@ -3837,7 +3836,7 @@ describe('BrowserWindow module', () => {
const w = new BrowserWindow({ resizable: false });
w.once('enter-full-screen', async () => {
expect(w.resizable).to.be.true('resizable');
await tick();
await delay();
w.setFullScreen(false);
});
w.once('leave-full-screen', () => {
@ -3853,7 +3852,7 @@ describe('BrowserWindow module', () => {
const w = new BrowserWindow();
w.once('enter-full-screen', async () => {
expect(w.isFullScreen()).to.be.true('isFullScreen');
await tick();
await delay();
w.setFullScreen(false);
});
w.once('leave-full-screen', () => {
@ -3887,9 +3886,9 @@ describe('BrowserWindow module', () => {
const w = new BrowserWindow();
w.once('enter-full-screen', async () => {
expect(w.isFullScreen()).to.be.true('isFullScreen');
await tick();
await delay();
w.setKiosk(true);
await tick();
await delay();
w.setKiosk(false);
expect(w.isFullScreen()).to.be.true('isFullScreen');
w.setFullScreen(false);