mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

build: fix missing dependency resulting in a random build failure (#25943)

Browse source 
* build: fix missing dependency resulting in a random build failure

* build: pref_names.h #includes files generated by separate GN targets,
  any sources that include that file have to live in a target that depends
  on the target it comes from

* fixup! build: fix missing dependency resulting in a random build failure

* fixup! build: fix missing dependency resulting in a random build failure
This commit is contained in:
mzajaczkowski 2020-10-15 22:41:05 +02:00 committed by GitHub
parent beaed6c434
commit 1c44bb8e74
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
chromium_src/BUILD.gn
View file

@ -367,6 +367,7 @@ source_set("chrome_spellchecker") {
sources = [] sources = []
deps = [] deps = []
libs = [] libs = []
public_deps = []
if (enable_builtin_spellchecker) { if (enable_builtin_spellchecker) {
sources += [ sources += [
@ -384,7 +385,6 @@ source_set("chrome_spellchecker") {
"//chrome/browser/spellchecker/spellcheck_language_policy_handler.h", "//chrome/browser/spellchecker/spellcheck_language_policy_handler.h",
"//chrome/browser/spellchecker/spellcheck_service.cc", "//chrome/browser/spellchecker/spellcheck_service.cc",
"//chrome/browser/spellchecker/spellcheck_service.h", "//chrome/browser/spellchecker/spellcheck_service.h",
"//chrome/common/pref_names.h",
] ]
if (has_spellcheck_panel) { if (has_spellcheck_panel) {
@ -407,9 +407,11 @@ source_set("chrome_spellchecker") {
"//components/spellcheck:buildflags", "//components/spellcheck:buildflags",
"//components/sync", "//components/sync",
] ]
public_deps += [ "//chrome/common:constants" ]
} }
public_deps = [ public_deps += [
"//components/spellcheck/browser", "//components/spellcheck/browser",
"//components/spellcheck/common", "//components/spellcheck/common",
"//components/spellcheck/renderer", "//components/spellcheck/renderer",