singletons that are retroactively turned into EventEmitters should call the EventEmitter ctor

2017-11-01 23:05:27 -05:00 · 2017-11-01 23:05:27 -05:00 · 1c09dede1a
commit 1c09dede1a
parent 577012370e
7 changed files with 14 additions and 0 deletions
--- a/lib/browser/api/auto-updater/auto-updater-native.js
+++ b/lib/browser/api/auto-updater/auto-updater-native.js
@ -1,6 +1,8 @@
 const EventEmitter = require('events').EventEmitter
 const {autoUpdater, AutoUpdater} = process.atomBinding('auto_updater')

+// AutoUpdater is an EventEmitter.
 Object.setPrototypeOf(AutoUpdater.prototype, EventEmitter.prototype)
+EventEmitter.call(autoUpdater)

 module.exports = autoUpdater