Revert "sec: deprecate some webPreference defaults to be secure-by-default (#14284)" (#14380)

This reverts commit 66d6ba8689.
This commit is contained in:
Samuel Attard 2018-08-30 09:57:49 +12:00 committed by GitHub
parent 66d6ba8689
commit 1b7418fb7b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 43 additions and 100 deletions

View file

@ -293,10 +293,6 @@ WebContents.prototype._init = function () {
ipcMain.emit(channel, event, ...args)
})
this.on('-deprecated-default', function (event, key, oldDefault, newDefault) {
deprecate.warnDefault(key, oldDefault, newDefault)
})
// Handle context menu action request from pepper plugin.
this.on('pepper-context-menu', function (event, params, callback) {
// Access Menu via electron.Menu to prevent circular require.

View file

@ -31,12 +31,6 @@ deprecate.warn = (oldName, newName) => {
return deprecate.log(`'${oldName}' is deprecated. Use '${newName}' instead.`)
}
deprecate.warnDefault = (propName, oldDefault, newDefault) => {
return deprecate.log(`The default value of '${propName}' is changing from \
'${oldDefault}' to '${newDefault}' in a future release. If you want to keep \
the current value, please explicitly declare the property.`)
}
let deprecationHandler = null
// Print deprecation message.

View file

@ -61,13 +61,6 @@ const getIsRemoteProtocol = function () {
* @returns {boolean} Is a CSP with `unsafe-eval` set?
*/
const isUnsafeEvalEnabled = function () {
// FIXME(MarshallOfSound): Although not exactly true, this warning is incorrect
// when contextIsolation is enabled
// FIXME(MarshallOfSound): Once remote issues have gone away we can remove
// the falsey check
const prefs = getWebPreferences()
if (prefs && prefs.contextIsolation) return false
try {
//eslint-disable-next-line
new Function('');