mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: add shell.trashItem() to replace shell.moveItemToTrash() (#25114)

Browse source
This commit is contained in:
Jeremy Rose 2020-09-02 10:32:33 -07:00 • committed by GitHub
parent e9e7eee25e
commit 1b6534b326
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 212 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

20
shell/common/api/electron_api_shell.cc
View file

@ -94,6 +94,25 @@ bool MoveItemToTrash(gin::Arguments* args) {
return platform_util::MoveItemToTrash(full_path, delete_on_fail);
}
v8::Local<v8::Promise> TrashItem(v8::Isolate* isolate,
const base::FilePath& path) {
gin_helper::Promise<void> promise(isolate);
v8::Local<v8::Promise> handle = promise.GetHandle();
platform_util::TrashItem(
path, base::BindOnce(
[](gin_helper::Promise<void> promise, bool success,
const std::string& error) {
if (success) {
promise.Resolve();
} else {
promise.RejectWithErrorMessage(error);
}
},
std::move(promise)));
return handle;
}
#if defined(OS_WIN)
bool WriteShortcutLink(const base::FilePath& shortcut_path,
gin_helper::Arguments* args) {
@ -158,6 +177,7 @@ void Initialize(v8::Local<v8::Object> exports,
dict.SetMethod("openPath", &OpenPath);
dict.SetMethod("openExternal", &OpenExternal);
dict.SetMethod("moveItemToTrash", &MoveItemToTrash);
dict.SetMethod("trashItem", &TrashItem);
dict.SetMethod("beep", &platform_util::Beep);
#if defined(OS_WIN)
dict.SetMethod("writeShortcutLink", &WriteShortcutLink);