mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: Generate breakpad symbols for GN release builds (#14791)

Browse source 
* Use chromium 's generate_breakpad_symbols.py

* Add breakpad symbol gen to CI.
This commit is contained in:
John Kleinschmidt 2018-09-26 14:56:05 -04:00 • committed by GitHub
parent 49f9019007
commit 1b4d425876
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 91 additions and 311 deletions
Download patch file Download diff file Expand all files Collapse all files

100
script/dump-symbols.py
View file

@ -1,62 +1,88 @@
#!/usr/bin/env python
import argparse
import os
import sys
from lib.config import PLATFORM
from lib.util import electron_gyp, execute, rm_rf
from lib.config import PLATFORM, enable_verbose_mode, is_verbose_mode
from lib.gn import gn
from lib.util import execute, rm_rf
ELECTRON_ROOT = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
SOURCE_ROOT = os.path.abspath(os.path.dirname(ELECTRON_ROOT))
RELEASE_PATH = os.path.join('out', 'Release')
SOURCE_ROOT = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
DIST_DIR = os.path.join(SOURCE_ROOT, 'dist')
OUT_DIR = os.path.join(SOURCE_ROOT, 'out', 'R')
CHROMIUM_DIR = os.path.join(SOURCE_ROOT, 'vendor', 'download',
'libchromiumcontent', 'static_library')
def main(destination):
rm_rf(destination)
(project_name, product_name) = get_names_from_gyp()
def main():
args = parse_args()
if args.verbose:
enable_verbose_mode()
rm_rf(args.destination)
source_root = os.path.abspath(args.source_root)
build_path = os.path.join(source_root, args.build_dir)
product_name = gn(build_path).args().get_string('electron_product_name')
project_name = gn(build_path).args().get_string('electron_project_name')
if PLATFORM in ['darwin', 'linux']:
generate_breakpad_symbols = os.path.join(SOURCE_ROOT, 'tools', 'posix',
'generate_breakpad_symbols.py')
if PLATFORM == 'darwin':
#macOS has an additional helper app; provide the path to that binary also
main_app = os.path.join(OUT_DIR, '{0}.app'.format(product_name),
main_app = os.path.join(build_path, '{0}.app'.format(product_name),
'Contents', 'MacOS', product_name)
helper_name = product_name + " Helper"
helper_app = os.path.join(OUT_DIR, '{0}.app'.format(helper_name),
helper_app = os.path.join(build_path, '{0}.app'.format(helper_name),
'Contents', 'MacOS', product_name + " Helper")
binaries = [main_app, helper_app]
for binary in binaries:
generate_posix_symbols(binary, source_root, build_path,
args.destination)
else:
binaries = [os.path.join(OUT_DIR, project_name)]
args = [
'--build-dir={0}'.format(OUT_DIR),
'--symbols-dir={0}'.format(destination),
'--libchromiumcontent-dir={0}'.format(CHROMIUM_DIR),
'--clear',
'--jobs=16',
]
for binary in binaries:
args += '--binary={0}'.format(binary),
binary = os.path.join(build_path, project_name)
generate_posix_symbols(binary, source_root, build_path,
args.destination)
else:
generate_breakpad_symbols = os.path.join(SOURCE_ROOT, 'tools', 'win',
generate_breakpad_symbols = os.path.join(ELECTRON_ROOT, 'tools', 'win',
'generate_breakpad_symbols.py')
args = [
'--symbols-dir={0}'.format(destination),
'--symbols-dir={0}'.format(args.destination),
'--jobs=16',
os.path.relpath(OUT_DIR),
]
os.path.relpath(build_path),
]
execute([sys.executable, generate_breakpad_symbols] + args)
execute([sys.executable, generate_breakpad_symbols] + args)
def get_names_from_gyp():
variables = electron_gyp()
return (variables['project_name%'], variables['product_name%'])
def generate_posix_symbols(binary, source_root, build_dir, destination):
generate_breakpad_symbols = os.path.join(source_root, 'components', 'crash',
'content', 'tools',
'generate_breakpad_symbols.py')
args = [
'--build-dir={0}'.format(build_dir),
'--symbols-dir={0}'.format(destination),
'--jobs=16',
'--binary={0}'.format(binary),
]
if is_verbose_mode():
args += ['-v']
execute([sys.executable, generate_breakpad_symbols] + args)
def parse_args():
parser = argparse.ArgumentParser(description='Create breakpad symbols')
parser.add_argument('-b', '--build-dir',
help='Path to an Electron build folder. \
Relative to the --source-root.',
default=RELEASE_PATH,
required=False)
parser.add_argument('-d', '--destination',
help='Path to save symbols to.',
default=None,
required=True)
parser.add_argument('-s', '--source-root',
help='Path to the src folder.',
default=SOURCE_ROOT,
required=False)
parser.add_argument('-v', '--verbose',
action='store_true',
help='Prints the output of the subprocesses')
return parser.parse_args()
if __name__ == '__main__':
sys.exit(main(sys.argv[1]))
sys.exit(main())