mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't use this.skip() since after hooks won't be run

Browse source
This commit is contained in:
Kevin Sawicki 2016-11-29 10:56:58 -08:00
parent 217848ca52
commit 1afa41477d
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spec/api-browser-window-spec.js
View file

@ -523,7 +523,7 @@ describe('browser-window module', function () {
describe('BrowserWindow.setAppDetails(options)', function () { describe('BrowserWindow.setAppDetails(options)', function () {
it('supports setting the app details', function () { it('supports setting the app details', function () {
if (process.platform !== 'win32') return this.skip() if (process.platform !== 'win32') return
const iconPath = path.join(fixtures, 'assets', 'icon.ico') const iconPath = path.join(fixtures, 'assets', 'icon.ico')
@ -660,7 +660,7 @@ describe('browser-window module', function () {
describe('"zoomToPageWidth" option', function () { describe('"zoomToPageWidth" option', function () {
it('sets the window width to the page width when used', function () { it('sets the window width to the page width when used', function () {
if (process.platform !== 'darwin') return this.skip() if (process.platform !== 'darwin') return
w.destroy() w.destroy()
w = new BrowserWindow({ w = new BrowserWindow({
@ -1723,7 +1723,7 @@ describe('browser-window module', function () {
describe('previewFile', function () { describe('previewFile', function () {
it('opens the path in Quick Look on macOS', function () { it('opens the path in Quick Look on macOS', function () {
if (process.platform !== 'darwin') return this.skip() if (process.platform !== 'darwin') return
assert.doesNotThrow(function () { assert.doesNotThrow(function () {
w.previewFile(__filename) w.previewFile(__filename)

2
spec/api-clipboard-spec.js
View file

@ -87,7 +87,7 @@ describe('clipboard module', function () {
describe('clipboard.read/writeFindText(text)', function () { describe('clipboard.read/writeFindText(text)', function () {
it('reads and write text to the find pasteboard', function () { it('reads and write text to the find pasteboard', function () {
if (process.platform !== 'darwin') return this.skip() if (process.platform !== 'darwin') return
clipboard.writeFindText('find this') clipboard.writeFindText('find this')
assert.equal(clipboard.readFindText(), 'find this') assert.equal(clipboard.readFindText(), 'find this')