Merge pull request #9237 from electron/root-modules-describe
Add root describe to modules spec
This commit is contained in:
Kevin Sawicki
GitHub
commit
1a49374b4c
1 changed files with 104 additions and 104 deletions
|
|
@ -1,63 +1,63 @@
|
||||||
const assert = require('assert')
|
const assert = require('assert')
|
||||||
const Module = require('module')
|
const Module = require('module')
|
||||||
const path = require('path')
|
const path = require('path')
|
||||||
const temp = require('temp')
|
|
||||||
const {remote} = require('electron')
|
const {remote} = require('electron')
|
||||||
const {BrowserWindow} = remote
|
const {BrowserWindow} = remote
|
||||||
const {closeWindow} = require('./window-helpers')
|
const {closeWindow} = require('./window-helpers')
|
||||||
|
|
||||||
describe('third-party module', function () {
|
describe('modules support', function () {
|
||||||
var fixtures = path.join(__dirname, 'fixtures')
|
var fixtures = path.join(__dirname, 'fixtures')
|
||||||
temp.track()
|
|
||||||
|
|
||||||
if (process.platform !== 'win32' || process.execPath.toLowerCase().indexOf('\\out\\d\\') === -1) {
|
describe('third-party module', function () {
|
||||||
describe('runas', function () {
|
if (process.platform !== 'win32' || process.execPath.toLowerCase().indexOf('\\out\\d\\') === -1) {
|
||||||
it('can be required in renderer', function () {
|
describe('runas', function () {
|
||||||
require('runas')
|
it('can be required in renderer', function () {
|
||||||
|
require('runas')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('can be required in node binary', function (done) {
|
||||||
|
var runas = path.join(fixtures, 'module', 'runas.js')
|
||||||
|
var child = require('child_process').fork(runas)
|
||||||
|
child.on('message', function (msg) {
|
||||||
|
assert.equal(msg, 'ok')
|
||||||
|
done()
|
||||||
|
})
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
it('can be required in node binary', function (done) {
|
describe('ffi', function () {
|
||||||
var runas = path.join(fixtures, 'module', 'runas.js')
|
if (process.platform === 'win32') return
|
||||||
var child = require('child_process').fork(runas)
|
|
||||||
child.on('message', function (msg) {
|
it('does not crash', function () {
|
||||||
assert.equal(msg, 'ok')
|
var ffi = require('ffi')
|
||||||
done()
|
var libm = ffi.Library('libm', {
|
||||||
|
ceil: ['double', ['double']]
|
||||||
|
})
|
||||||
|
assert.equal(libm.ceil(1.5), 2)
|
||||||
|
})
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('q', function () {
|
||||||
|
var Q = require('q')
|
||||||
|
describe('Q.when', function () {
|
||||||
|
it('emits the fullfil callback', function (done) {
|
||||||
|
Q(true).then(function (val) {
|
||||||
|
assert.equal(val, true)
|
||||||
|
done()
|
||||||
|
})
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
describe('ffi', function () {
|
describe('coffee-script', function () {
|
||||||
if (process.platform === 'win32') return
|
it('can be registered and used to require .coffee files', function () {
|
||||||
|
assert.doesNotThrow(function () {
|
||||||
it('does not crash', function () {
|
require('coffee-script').register()
|
||||||
var ffi = require('ffi')
|
|
||||||
var libm = ffi.Library('libm', {
|
|
||||||
ceil: ['double', ['double']]
|
|
||||||
})
|
})
|
||||||
assert.equal(libm.ceil(1.5), 2)
|
assert.strictEqual(require('./fixtures/module/test.coffee'), true)
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
}
|
|
||||||
|
|
||||||
describe('q', function () {
|
|
||||||
var Q = require('q')
|
|
||||||
describe('Q.when', function () {
|
|
||||||
it('emits the fullfil callback', function (done) {
|
|
||||||
Q(true).then(function (val) {
|
|
||||||
assert.equal(val, true)
|
|
||||||
done()
|
|
||||||
})
|
|
||||||
})
|
|
||||||
})
|
|
||||||
})
|
|
||||||
|
|
||||||
describe('coffee-script', function () {
|
|
||||||
it('can be registered and used to require .coffee files', function () {
|
|
||||||
assert.doesNotThrow(function () {
|
|
||||||
require('coffee-script').register()
|
|
||||||
})
|
|
||||||
assert.strictEqual(require('./fixtures/module/test.coffee'), true)
|
|
||||||
})
|
|
||||||
})
|
})
|
||||||
|
|
||||||
describe('global variables', function () {
|
describe('global variables', function () {
|
||||||
|
|
@ -79,79 +79,79 @@ describe('third-party module', function () {
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
})
|
|
||||||
|
|
||||||
describe('Module._nodeModulePaths', function () {
|
describe('Module._nodeModulePaths', function () {
|
||||||
describe('when the path is inside the resources path', function () {
|
describe('when the path is inside the resources path', function () {
|
||||||
it('does not include paths outside of the resources path', function () {
|
it('does not include paths outside of the resources path', function () {
|
||||||
let modulePath = process.resourcesPath
|
let modulePath = process.resourcesPath
|
||||||
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
||||||
path.join(process.resourcesPath, 'node_modules')
|
path.join(process.resourcesPath, 'node_modules')
|
||||||
])
|
])
|
||||||
|
|
||||||
modulePath = process.resourcesPath + '-foo'
|
modulePath = process.resourcesPath + '-foo'
|
||||||
let nodeModulePaths = Module._nodeModulePaths(modulePath)
|
let nodeModulePaths = Module._nodeModulePaths(modulePath)
|
||||||
assert(nodeModulePaths.includes(path.join(modulePath, 'node_modules')))
|
assert(nodeModulePaths.includes(path.join(modulePath, 'node_modules')))
|
||||||
assert(nodeModulePaths.includes(path.join(modulePath, '..', 'node_modules')))
|
assert(nodeModulePaths.includes(path.join(modulePath, '..', 'node_modules')))
|
||||||
|
|
||||||
modulePath = path.join(process.resourcesPath, 'foo')
|
modulePath = path.join(process.resourcesPath, 'foo')
|
||||||
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
||||||
path.join(process.resourcesPath, 'foo', 'node_modules'),
|
path.join(process.resourcesPath, 'foo', 'node_modules'),
|
||||||
path.join(process.resourcesPath, 'node_modules')
|
path.join(process.resourcesPath, 'node_modules')
|
||||||
])
|
])
|
||||||
|
|
||||||
modulePath = path.join(process.resourcesPath, 'node_modules', 'foo')
|
modulePath = path.join(process.resourcesPath, 'node_modules', 'foo')
|
||||||
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
||||||
path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules'),
|
path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules'),
|
||||||
path.join(process.resourcesPath, 'node_modules')
|
path.join(process.resourcesPath, 'node_modules')
|
||||||
])
|
])
|
||||||
|
|
||||||
modulePath = path.join(process.resourcesPath, 'node_modules', 'foo', 'bar')
|
modulePath = path.join(process.resourcesPath, 'node_modules', 'foo', 'bar')
|
||||||
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
||||||
path.join(process.resourcesPath, 'node_modules', 'foo', 'bar', 'node_modules'),
|
path.join(process.resourcesPath, 'node_modules', 'foo', 'bar', 'node_modules'),
|
||||||
path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules'),
|
path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules'),
|
||||||
path.join(process.resourcesPath, 'node_modules')
|
path.join(process.resourcesPath, 'node_modules')
|
||||||
])
|
])
|
||||||
|
|
||||||
modulePath = path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules', 'bar')
|
modulePath = path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules', 'bar')
|
||||||
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
||||||
path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules', 'bar', 'node_modules'),
|
path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules', 'bar', 'node_modules'),
|
||||||
path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules'),
|
path.join(process.resourcesPath, 'node_modules', 'foo', 'node_modules'),
|
||||||
path.join(process.resourcesPath, 'node_modules')
|
path.join(process.resourcesPath, 'node_modules')
|
||||||
])
|
])
|
||||||
})
|
|
||||||
})
|
|
||||||
|
|
||||||
describe('when the path is outside the resources path', function () {
|
|
||||||
it('includes paths outside of the resources path', function () {
|
|
||||||
let modulePath = path.resolve('/foo')
|
|
||||||
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
|
||||||
path.join(modulePath, 'node_modules'),
|
|
||||||
path.resolve('/node_modules')
|
|
||||||
])
|
|
||||||
})
|
|
||||||
})
|
|
||||||
})
|
|
||||||
|
|
||||||
describe('require', () => {
|
|
||||||
describe('when loaded URL is not file: protocol', () => {
|
|
||||||
let w
|
|
||||||
|
|
||||||
beforeEach(() => {
|
|
||||||
w = new BrowserWindow({
|
|
||||||
show: false
|
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
afterEach(async () => {
|
describe('when the path is outside the resources path', function () {
|
||||||
await closeWindow(w)
|
it('includes paths outside of the resources path', function () {
|
||||||
w = null
|
let modulePath = path.resolve('/foo')
|
||||||
|
assert.deepEqual(Module._nodeModulePaths(modulePath), [
|
||||||
|
path.join(modulePath, 'node_modules'),
|
||||||
|
path.resolve('/node_modules')
|
||||||
|
])
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
})
|
||||||
|
|
||||||
it('searches for module under app directory', async () => {
|
describe('require', () => {
|
||||||
w.loadURL('about:blank')
|
describe('when loaded URL is not file: protocol', () => {
|
||||||
const result = await w.webContents.executeJavaScript('typeof require("q").when')
|
let w
|
||||||
assert.equal(result, 'function')
|
|
||||||
|
beforeEach(() => {
|
||||||
|
w = new BrowserWindow({
|
||||||
|
show: false
|
||||||
|
})
|
||||||
|
})
|
||||||
|
|
||||||
|
afterEach(async () => {
|
||||||
|
await closeWindow(w)
|
||||||
|
w = null
|
||||||
|
})
|
||||||
|
|
||||||
|
it('searches for module under app directory', async () => {
|
||||||
|
w.loadURL('about:blank')
|
||||||
|
const result = await w.webContents.executeJavaScript('typeof require("q").when')
|
||||||
|
assert.equal(result, 'function')
|
||||||
|
})
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue