mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Discard is_guest_, use type_ instead

Browse source
This commit is contained in:
Cheng Zhao 2015-06-24 22:23:38 +08:00
parent 2bfa9da82e
commit 19ca011735
5 changed files with 24 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/browser/common_web_contents_delegate.h
View file

@ -23,7 +23,7 @@ class CommonWebContentsDelegate
: public brightray::DefaultWebContentsDelegate,
public brightray::InspectableWebContentsDelegate {
public:
explicit CommonWebContentsDelegate(bool is_guest);
CommonWebContentsDelegate();
virtual ~CommonWebContentsDelegate();
// Create a InspectableWebContents object and takes onwership of
@ -44,8 +44,6 @@ class CommonWebContentsDelegate
return web_contents_.get();
}
bool is_guest() const { return is_guest_; }
protected:
// content::WebContentsDelegate:
content::WebContents* OpenURLFromTab(
@ -55,7 +53,6 @@ class CommonWebContentsDelegate
bool user_gesture,
bool last_unlocked_by_target) override;
bool CanOverscrollContent() const override;
bool IsPopupOrPanel(const content::WebContents* source) const override;
content::JavaScriptDialogManager* GetJavaScriptDialogManager(
content::WebContents* source) override;
content::ColorChooser* OpenColorChooser(
@ -92,9 +89,6 @@ class CommonWebContentsDelegate
// Set fullscreen mode triggered by html api.
void SetHtmlApiFullscreen(bool enter_fullscreen);
// Whether this is guest WebContents or NativeWindow.
const bool is_guest_;
// The window that this WebContents belongs to.
NativeWindow* owner_window_;