mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: remove unused isolate argument from Cookies constructor (#44921)

Browse source 
* chore: remove unused isolate argument from Cookies constructor

unused since the ginify cookies refactor in Mar 2020, commit 22202255

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: constructor only takes one arg now, so mark it explicit

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-12-02 13:55:14 -06:00 • committed by GitHub
parent baeabc03a3
commit 19c8b0f01f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
shell/browser/api/electron_api_cookies.cc
View file

@ -292,8 +292,8 @@ std::string StringToCookieSameSite(const std::string* str_ptr,
gin::WrapperInfo Cookies::kWrapperInfo = {gin::kEmbedderNativeGin}; gin::WrapperInfo Cookies::kWrapperInfo = {gin::kEmbedderNativeGin};
Cookies::Cookies(v8::Isolate* isolate, ElectronBrowserContext* browser_context) Cookies::Cookies(ElectronBrowserContext* browser_context)
: browser_context_(browser_context) { : browser_context_{browser_context} {
cookie_change_subscription_ = cookie_change_subscription_ =
browser_context_->cookie_change_notifier()->RegisterCookieChangeCallback( browser_context_->cookie_change_notifier()->RegisterCookieChangeCallback(
base::BindRepeating(&Cookies::OnCookieChanged, base::BindRepeating(&Cookies::OnCookieChanged,
@ -458,7 +458,7 @@ void Cookies::OnCookieChanged(const net::CookieChangeInfo& change) {
// static // static
gin::Handle<Cookies> Cookies::Create(v8::Isolate* isolate, gin::Handle<Cookies> Cookies::Create(v8::Isolate* isolate,
ElectronBrowserContext* browser_context) { ElectronBrowserContext* browser_context) {
return gin::CreateHandle(isolate, new Cookies(isolate, browser_context)); return gin::CreateHandle(isolate, new Cookies{browser_context});
} }
gin::ObjectTemplateBuilder Cookies::GetObjectTemplateBuilder( gin::ObjectTemplateBuilder Cookies::GetObjectTemplateBuilder(

2
shell/browser/api/electron_api_cookies.h
View file

@ -50,7 +50,7 @@ class Cookies final : public gin::Wrappable<Cookies>,
Cookies& operator=(const Cookies&) = delete; Cookies& operator=(const Cookies&) = delete;
protected: protected:
Cookies(v8::Isolate* isolate, ElectronBrowserContext* browser_context); explicit Cookies(ElectronBrowserContext* browser_context);
~Cookies() override; ~Cookies() override;
v8::Local<v8::Promise> Get(v8::Isolate*, v8::Local<v8::Promise> Get(v8::Isolate*,