From 19b6ba044b523580d60046e199ecd6ca025e78ef Mon Sep 17 00:00:00 2001
From: Thiago de Arruda <tpadilha84@gmail.com>
Date: Fri, 28 Apr 2017 11:21:53 -0300
Subject: [PATCH] Fix context leak in ObjectLifeMonitor.

The RemoteObjectFreer class is keeping the context alive even when the window is
closed. For electron applications that use sandbox, this will cause a memory
leak every time a new window is created with `window.open`.

Close #9191
---
 atom/common/api/object_life_monitor.cc | 3 +--
 atom/common/api/object_life_monitor.h  | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/atom/common/api/object_life_monitor.cc b/atom/common/api/object_life_monitor.cc
index cd5537e8874c..cc68130d34bd 100644
--- a/atom/common/api/object_life_monitor.cc
+++ b/atom/common/api/object_life_monitor.cc
@@ -12,8 +12,7 @@ namespace atom {
 
 ObjectLifeMonitor::ObjectLifeMonitor(v8::Isolate* isolate,
                                      v8::Local<v8::Object> target)
-    : context_(isolate, isolate->GetCurrentContext()),
-      target_(isolate, target),
+    : target_(isolate, target),
       weak_ptr_factory_(this) {
   target_.SetWeak(this, OnObjectGC, v8::WeakCallbackType::kParameter);
 }
diff --git a/atom/common/api/object_life_monitor.h b/atom/common/api/object_life_monitor.h
index 73030864b933..e047960e8130 100644
--- a/atom/common/api/object_life_monitor.h
+++ b/atom/common/api/object_life_monitor.h
@@ -22,7 +22,6 @@ class ObjectLifeMonitor {
   static void OnObjectGC(const v8::WeakCallbackInfo<ObjectLifeMonitor>& data);
   static void Free(const v8::WeakCallbackInfo<ObjectLifeMonitor>& data);
 
-  v8::Global<v8::Context> context_;
   v8::Global<v8::Object> target_;
 
   base::WeakPtrFactory<ObjectLifeMonitor> weak_ptr_factory_;