mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: missing HandleScope in RemoveFromParentChildWindows (#46758)

Browse source
This commit is contained in:
Shelley Vohr 2025-04-25 14:04:25 +02:00 • committed by GitHub
parent 51dbe69e45
commit 1976e935e7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/api/electron_api_base_window.cc
View file

@ -1161,8 +1161,10 @@ void BaseWindow::RemoveFromParentChildWindows() {
if (parent_window_.IsEmpty())
return;
v8::Isolate* isolate = JavascriptEnvironment::GetIsolate();
v8::HandleScope handle_scope(isolate);
gin::Handle<BaseWindow> parent;
if (!gin::ConvertFromV8(isolate(), GetParentWindow(), &parent) ||
if (!gin::ConvertFromV8(isolate, GetParentWindow(), &parent) ||
parent.IsEmpty()) {
return;
}