mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Add 'new-window' event for <webview>

Browse source
This commit is contained in:
Cheng Zhao 2014-10-25 13:21:09 +08:00
parent d8447524cb
commit 194ed3884c
4 changed files with 27 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

25
atom/browser/api/atom_api_web_contents.cc
View file

@ -78,6 +78,21 @@ bool WebContents::AddMessageToConsole(content::WebContents* source,
return true;
}
bool WebContents::ShouldCreateWebContents(
content::WebContents* web_contents,
int route_id,
WindowContainerType window_container_type,
const base::string16& frame_name,
const GURL& target_url,
const std::string& partition_id,
content::SessionStorageNamespace* session_storage_namespace) {
base::ListValue args;
args.AppendString(target_url.spec());
args.AppendString(partition_id);
Emit("new-window", args);
return false;
}
void WebContents::CloseContents(content::WebContents* source) {
Emit("close");
}
@ -210,14 +225,8 @@ void WebContents::WillAttach(content::WebContents* embedder_web_contents,
content::WebContents* WebContents::CreateNewGuestWindow(
const content::WebContents::CreateParams& create_params) {
auto web_contents = content::WebContents::Create(create_params);
// TODO Currently we just retain the web_contents on V8's heap, which will be
// garbage collected later, we should provide a way to let users make use of
// this WebContents.
mate::Handle<WebContents> managed = CreateFrom(
v8::Isolate::GetCurrent(), web_contents);
managed->storage_.reset(web_contents);
return web_contents;
NOTREACHED() << "Should not create new window from guest";
return nullptr;
}
void WebContents::DidAttach() {