deprecate boolean highlightMode param (#11993)

* deprecate boolean highlightMode param

* add process.noDeprecations check

* fix native method override

* add todo
This commit is contained in:
shelley vohr 2018-02-20 23:30:32 -05:00 committed by Charles Kerr
parent 719e5a93b4
commit 193febd18c
2 changed files with 24 additions and 0 deletions

View file

@ -39,6 +39,16 @@ struct Converter<atom::TrayIcon::HighlightMode> {
return true;
}
}
bool highlight;
if (ConvertFromV8(isolate, val, &highlight)) {
if (highlight)
*out = atom::TrayIcon::HighlightMode::SELECTION;
else
*out = atom::TrayIcon::HighlightMode::NEVER;
return true;
}
return false;
}
};