mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: remove catch-all HandleScope (#22531)

Browse source
This commit is contained in:
Jeremy Apthorp 2020-03-10 18:16:58 -07:00 • committed by GitHub
parent 4bca5205bb
commit 19314d3caf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 131 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

3
shell/common/gin_helper/wrappable_base.h
View file

@ -52,6 +52,8 @@ class WrappableBase {
// Helper to init with arguments.
void InitWithArgs(gin::Arguments* args);
v8::Global<v8::Object> wrapper_; // Weak
private:
static void FirstWeakCallback(
const v8::WeakCallbackInfo<WrappableBase>& data);
@ -59,7 +61,6 @@ class WrappableBase {
const v8::WeakCallbackInfo<WrappableBase>& data);
v8::Isolate* isolate_ = nullptr;
v8::Global<v8::Object> wrapper_; // Weak
DISALLOW_COPY_AND_ASSIGN(WrappableBase);
};