fix: remove catch-all HandleScope (#22531)

2020-03-10 18:16:58 -07:00 · 2020-03-10 18:16:58 -07:00 · 19314d3caf
commit 19314d3caf
parent 4bca5205bb
21 changed files with 131 additions and 75 deletions
--- a/shell/common/gin_helper/event_emitter.cc
+++ b/shell/common/gin_helper/event_emitter.cc
@ -38,6 +38,7 @@ v8::Local<v8::Object> CreateEvent(v8::Isolate* isolate,
  }

  v8::Local<v8::Context> context = isolate->GetCurrentContext();
+  CHECK(!context.IsEmpty());
  v8::Local<v8::Object> event =
      v8::Local<v8::ObjectTemplate>::New(isolate, event_template)
          ->NewInstance(context)