From 18e15a1e53cc9efc1b5e99295c84a0ca3a1b130d Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 8 Feb 2017 12:51:24 -0800 Subject: [PATCH] Add spec for rejecting using old signature --- spec/api-session-spec.js | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/spec/api-session-spec.js b/spec/api-session-spec.js index 4d6fc64c4de2..f8e0e27dc34b 100644 --- a/spec/api-session-spec.js +++ b/spec/api-session-spec.js @@ -569,17 +569,33 @@ describe('session module', function () { w.loadURL(`https://127.0.0.1:${server.address().port}`) }) - it('supports the old function signature', function (done) { - session.defaultSession.setCertificateVerifyProc(function (hostname, certificate, callback) { - assert.equal(hostname, '127.0.0.1') - callback(true) + describe('deprecated function signature', function () { + it('supports accepting the request', function (done) { + session.defaultSession.setCertificateVerifyProc(function (hostname, certificate, callback) { + assert.equal(hostname, '127.0.0.1') + callback(true) + }) + + w.webContents.once('did-finish-load', function () { + assert.equal(w.webContents.getTitle(), 'hello') + done() + }) + w.loadURL(`https://127.0.0.1:${server.address().port}`) }) - w.webContents.once('did-finish-load', function () { - assert.equal(w.webContents.getTitle(), 'hello') - done() + it('supports rejecting the request', function (done) { + session.defaultSession.setCertificateVerifyProc(function (hostname, certificate, callback) { + assert.equal(hostname, '127.0.0.1') + callback(false) + }) + + var url = `https://127.0.0.1:${server.address().port}` + w.webContents.once('did-finish-load', function () { + assert.equal(w.webContents.getTitle(), url) + done() + }) + w.loadURL(url) }) - w.loadURL(`https://127.0.0.1:${server.address().port}`) }) it('rejects the request when the callback is called with false', function (done) {